Add AbstractRetriever and remove duplicate implementations through inheritence

Author: webdevel

src/JsonSchema/Uri/Retrievers/AbstractRetriever.php

@@ -0,0 +1,35 @@
+<?php
+/**
+ * JsonSchema
+ * @filesource
+ */
+namespace JsonSchema\Uri\Retrievers;
+
+/**
+ * AbstractRetriever implements the default shared behavior
+ * that all decendant Retrievers should inherit
+ * @author Steven Garcia <webwhammy@gmail.com>
+ */
+abstract class AbstractRetriever implements UriRetrieverInterface
+{
+    /**
+     * Media content type
+     * @var string
+     */
+    protected $contentType;
+    
+    /**
+     * {@inheritDoc}
+     * @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::retrieve()
+     */
+    public abstract function retrieve($uri);
+    
+    /**
+     * {@inheritDoc}
+     * @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::getContentType()
+     */
+    public function getContentType()
+    {
+        return $this->contentType;
+    }
+}

src/JsonSchema/Uri/Retrievers/Curl.php

@@ -18,9 +18,8 @@
  *
  * @author Sander Coolen <sander@jibber.nl>
  */
-class Curl implements UriRetrieverInterface
+class Curl extends AbstractRetriever
 {
-    protected $contentType;
     protected $messageBody;
 
     public function __construct()
@@ -30,6 +29,10 @@ public function __construct()
         }
     }
 
+    /**
+     * {@inheritDoc}
+     * @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::retrieve()
+     */
     public function retrieve($uri)
     {
         $ch = curl_init();
@@ -75,9 +78,4 @@ protected function fetchContentType($response)
 
         return false;
     }
-
-    public function getContentType()
-    {
-        return $this->contentType;
-    }
-}
+}

src/JsonSchema/Uri/Retrievers/FileGetContents.php

@@ -16,11 +16,14 @@
  * 
  * @author Sander Coolen <sander@jibber.nl> 
  */
-class FileGetContents implements UriRetrieverInterface
+class FileGetContents extends AbstractRetriever
 {
-    protected $contentType;
     protected $messageBody;
 
+    /**
+     * {@inheritDoc}
+     * @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::retrieve()
+     */
     public function retrieve($uri)
     {
         $context = stream_context_create(array(
@@ -35,12 +38,12 @@ public function retrieve($uri)
         }
 
         $this->messageBody = $response;
-		if (! empty($http_response_header)) {
-			$this->fetchContentType($http_response_header);
-		} else {
-			// Could be a "file://" url or something else - fake up the response
-			$this->contentType = null;
-		}
+        if (! empty($http_response_header)) {
+            $this->fetchContentType($http_response_header);
+        } else {
+            // Could be a "file://" url or something else - fake up the response
+            $this->contentType = null;
+        }
 
         return $this->messageBody;
     }
@@ -70,9 +73,4 @@ protected static function getContentTypeMatchInHeader($header)
             return trim($match[1]);
         }
     }
-
-    public function getContentType()
-    {
-        return $this->contentType;
-    }
-}
+}

src/JsonSchema/Uri/Retrievers/PredefinedArray.php

@@ -18,10 +18,13 @@
  *
  *      $schema = $retriever->retrieve('http://acme.com/schemas/person#');
  */
-class PredefinedArray implements UriRetrieverInterface
+class PredefinedArray extends AbstractRetriever
 {
+    /**
+     * Contains schemas as URI => JSON
+     * @var array
+     */
     private $schemas;
-    private $contentType;
 
     /**
      * Constructor
@@ -34,9 +37,10 @@ public function __construct(array $schemas, $contentType = Validator::SCHEMA_MED
         $this->schemas     = $schemas;
         $this->contentType = $contentType;
     }
-
+    
     /**
      * {@inheritDoc}
+     * @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::retrieve()
      */
     public function retrieve($uri)
     {
@@ -49,12 +53,4 @@ public function retrieve($uri)
 
         return $this->schemas[$uri];
     }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getContentType()
-    {
-        return $this->contentType;
-    }
-}
+}