Update cvtRGBtoGray

Author: jamesnulliu

.clang-format

@@ -39,4 +39,4 @@ ConstructorInitializerIndentWidth:              4
 
 AlwaysBreakTemplateDeclarations: Yes
 
-ColumnLimit: 80
+ColumnLimit: 79

.clangd

@@ -1,3 +1,25 @@
+---
+If:
+  PathMatch: [.*\.c, .*\.h]
+CompileFlags:
+  Add: [-xc, -std=c11]
+  Remove: [-xc++, -std=c++*]
+Diagnostics:
+  ClangTidy:
+    Remove:
+      - modernize-*
+      - cppcoreguidelines-*
+      - performance-*
+      - google-*
+      - cert-dcl21-cpp
+      - cert-dcl58-cpp
+      - cert-err58-cpp
+      - misc-new-delete-overloads
+      - misc-non-private-member-variables-in-classes
+      - misc-uniqueptr-reset-release
+---
+If:
+  PathMatch: [.*\.cpp, .*\.cu, .*\.hpp, .*\.cuh]
 CompileFlags:
   Add: 
     - --no-cuda-version-check
@@ -35,9 +57,9 @@ Diagnostics:
 
     CheckOptions:
       readability-identifier-naming.VariableCase: aNy_CasE
-      readability-identifier-naming.ProtectedMemberCase: camelBack
-      readability-identifier-naming.PrivateMemberCase: camelBack
-      readability-identifier-naming.PublicMemberCase: camelBack
+      readability-identifier-naming.ProtectedMemberCase: aNy_CasE
+      readability-identifier-naming.PrivateMemberCase: aNy_CasE
+      readability-identifier-naming.PublicMemberCase: aNy_CasE
       readability-identifier-naming.NamespaceCase: lower_case
       readability-identifier-naming.EnumCase: camelBack
       readability-identifier-naming.ClassCase: CamelCase

.vscode/settings.json

@@ -25,11 +25,14 @@
         "--all-scopes-completion",
         "--completion-style=bundled",
         "--cross-file-rename",
-        "--header-insertion=iwyu",
+        "--header-insertion=never",
         "--header-insertion-decorators",
         "--background-index",
         "-j=8",
         "--pch-storage=memory",
         "--function-arg-placeholders=false",
     ],
+    "black-formatter.args": [
+        "--line-length=79"
+    ]
 }

README.md

@@ -13,7 +13,7 @@ pip install torch torchvision torchaudio
 To build the C++ part only (lib pmpp):
 
 ```bash
-bash scripts/build.sh -S ./csrc -B ./build
+bash scripts/build.sh
 ```
 
 Run ctest to test lib pmpp:

csrc/CMakeLists.txt

@@ -5,15 +5,12 @@ cmake_minimum_required(VERSION 3.30)
 project(VSC-CMAKE-CXX-TEMPLATE VERSION 1.0.0)
 
 # Common utility functions
+include(${PROJECT_SOURCE_DIR}/cmake/utils/logging.cmake)
 include(${PROJECT_SOURCE_DIR}/cmake/utils/common.cmake)
 
-log_info(${CMAKE_TOOLCHAIN_FILE})
+log_info("CMake Tookchain File Path: ${CMAKE_TOOLCHAIN_FILE}")
 
-# @see "./cmake/utils/variables.cmake"
 set_default_values(
-    # CMake project namespace:
-    # All the libs should have a alias with this namespace
-    # [NOTE] Change this to your own namespace
     PROJECT_NAMESPACE "pmpp::"
     FORCE_COLORED_OUTPUT ON
 )

csrc/cmake/utils/common.cmake

@@ -2,19 +2,21 @@ include(${CMAKE_CURRENT_LIST_DIR}/logging.cmake)
 
 # @func  set_default_values(<var1> <value1> <var2> <value2> ...)
 # @brief Set default values for variables;
-#        The variable will not be overwrite if it already has a value.
+# The variable will not be overwrite if it already has a value.
 function(set_default_values)
     math(EXPR ARG_COUNT "${ARGC} % 2")
+
     if(NOT ${ARG_COUNT} EQUAL 0)
         log_error("`set_default_values()` requires pairs of VAR_NAME and DEFAULT_VALUE")
     endif()
 
     math(EXPR LAST_INDEX "${ARGC} - 1")
+
     foreach(IDX RANGE 0 ${LAST_INDEX} 2)
         math(EXPR VALUE_IDX "${IDX} + 1")
         list(GET ARGV ${IDX} VAR_NAME)
         list(GET ARGV ${VALUE_IDX} DEFAULT_VALUE)
-        
+
         if(NOT DEFINED ${VAR_NAME})
             set(${VAR_NAME} ${DEFAULT_VALUE} PARENT_SCOPE)
         endif()
@@ -23,10 +25,10 @@ endfunction()
 
 # @func try_get_value(<var> HINTS <hint1> <hint2> ...)
 # @brief Try to assign value to <var> from hints or env:hints.
-#        $<var>_FOUND will be set to true if one of the hint found; Otherwise false.
+# $<var>_FOUND will be set to true if one of the hint found; Otherwise false.
 function(try_get_value VAR)
     cmake_parse_arguments(PARSE_ARGV 1 ARG "" "" "HINTS")
-    
+
     # First try each hint as a CMake variable
     foreach(hint IN LISTS ARG_HINTS)
         if(DEFINED ${hint})
@@ -35,7 +37,7 @@ function(try_get_value VAR)
             return()
         endif()
     endforeach()
-    
+
     # Then try each hint as an environment variable
     foreach(hint IN LISTS ARG_HINTS)
         if(DEFINED ENV{${hint}})
@@ -44,7 +46,7 @@ function(try_get_value VAR)
             return()
         endif()
     endforeach()
-    
+
     # If nothing found
     set(${VAR} "" PARENT_SCOPE)
     set(${VAR}_FOUND FALSE PARENT_SCOPE)

csrc/cmake/vcpkg-triplets/x64-linux-no-cxx11abi.cmake

@@ -4,6 +4,6 @@ set(VCPKG_LIBRARY_LINKAGE static)
 
 set(VCPKG_CMAKE_SYSTEM_NAME Linux)
 
-# Force old ABI off
+# Forcing the use of the old ABI
 set(ENV{CXXFLAGS} "$ENV{CXXFLAGS} -D_GLIBCXX_USE_CXX11_ABI=0")
 set(ENV{CFLAGS} "$ENV{CFLAGS} -D_GLIBCXX_USE_CXX11_ABI=0")

csrc/include/pmpp/basic/loggable_base.hpp

@@ -0,0 +1,48 @@
+#pragma once
+
+#include <spdlog/common.h>
+#include <spdlog/sinks/stdout_color_sinks.h>
+#include <spdlog/spdlog.h>
+#include <string>
+#include <utility>
+
+namespace pmpp::basic
+{
+class LoggableBase
+{
+public:
+    explicit LoggableBase(
+        const std::string& loggerName,
+        spdlog::level::level_enum level = spdlog::level::info,
+        const std::string& pattern =
+            "[%Y-%m-%d %H:%M:%S.%e] [%^%l%$] [%n] [%t] %v")
+        : m_logger(spdlog::stdout_color_mt(loggerName))
+    {
+        m_logger->set_level(level);
+        m_logger->set_pattern(pattern);
+    }
+
+    auto getLogger() -> std::shared_ptr<spdlog::logger>
+    {
+        return m_logger;
+    }
+
+    void setLogger(std::shared_ptr<spdlog::logger> logger)
+    {
+        m_logger = std::move(logger);
+    }
+
+    void setLevel(spdlog::level::level_enum level)
+    {
+        m_logger->set_level(level);
+    }
+
+    void setPattern(const std::string& pattern)
+    {
+        m_logger->set_pattern(pattern);
+    }
+
+protected:
+    std::shared_ptr<spdlog::logger> m_logger;
+};
+}  // namespace pmpp::basic