RDMR-1125 Do not interfere with predictive back #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a critical issue where the predictive back-to-home gesture
animation was being aborted. The loadUrl("javascript:...") method is
treated as a navigation event by the WebView. This had two negative
side-effects:
- Incorrectly added an entry to the WebView's history stack. This
caused canGoBack() to become true at the as soon as the application
opened, which prevented the Android system to take over and displaying
the animation when navigating back (out of the application)
- Executing this call synchronously within the
OnApplyWindowInsetsListener could interfere with the sensitive setup
phase of system animations, causing them to fail
Using evaluateJavascript is the modern practice for script execution and
it does not affect the navigation history. Also, by wrapping the call in
post(), the execution on the UI thread is deferred until the system is
stable. The system also handles application teardown gracefully by
discarding the post() Runnable if the associated view no longer exists.
References https://outsystemsrd.atlassian.net/browse/RDMR-1125
EiyuuZack
requested review from
Chuckytuh,
OS-kepatotorica,
OS-ruialves,
benmccarty91,
trevor-lambert and
usernuno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluateJavascript is the way. Read the commit message.
References https://outsystemsrd.atlassian.net/browse/RDMR-1125
BEFORE:
predictive-back-before.mp4
AFTER:
predictive-back-after.mp4