[Autobackout][FuncReg]Revert of change: a6d35e7

dlei6g · igcbot · commit 5646cf4bc23f · 2021-10-29T03:48:57.000+02:00
Fixed struct arg size bug

IGC stackcall spec limits struct argument promotion from pass-by-reference to pass-by-value, to 64-bits and 128-bits
respectively for function return values and arguments. This fixes a minor bug that cause promotion to fail at those sizes.
diff --git a/IGC/AdaptorCommon/LegalizeFunctionSignatures.cpp b/IGC/AdaptorCommon/LegalizeFunctionSignatures.cpp
@@ -151,7 +151,7 @@ inline bool isPromotableStructType(const Module& M, const Type* ty, bool isRetur
     if (ty->isPointerTy())
     {
         StructType* sTy = dyn_cast<StructType>(ty->getPointerElementType());
-        if (sTy && DL.getStructLayout(sTy)->getSizeInBits() <= maxSize)
+        if (sTy && DL.getStructLayout(sTy)->getSizeInBits() < maxSize)
         {
             for (const auto* EltTy : sTy->elements())
             {

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ inline bool isPromotableStructType(const Module& M, const Type* ty, bool isRetur`
`151`	`151`	`if (ty->isPointerTy())`
`152`	`152`	`{`
`153`	`153`	`StructType* sTy = dyn_cast<StructType>(ty->getPointerElementType());`
`154`		`- if (sTy && DL.getStructLayout(sTy)->getSizeInBits() <= maxSize)`
	`154`	`+ if (sTy && DL.getStructLayout(sTy)->getSizeInBits() < maxSize)`
`155`	`155`	`{`
`156`	`156`	`for (const auto* EltTy : sTy->elements())`
`157`	`157`	`{`