Commit 1f5193e
We compile SPIRV-Headers project and SPIRV-Tools project together in a single Visual Studio solution. Code of those are on external, open source repository. Sometimes we are witnesses of a random build break during SPIRV-Headers installation. We want to skip the installation process not only to avoid this issue, but also because we do not need it. I have added new CMake option SPIRV_HEADERS_SKIP_INSTALL to avoid installing SPIRV-Headers: KhronosGroup/SPIRV-Headers#131. However, recently SPIRV-Headers library has become an INTERFACE library. In the same time SPIRV-Tools sets property FOLDER quite often. This combination is not allowed by CMake. I have proposed another change to fix this conflict between libraries: KhronosGroup/SPIRV-Headers#132. But we do not need to compile SPIRV-Headers library at all. We just need to include its headers. So, finally I have decided to comment out instruction add_subdirectory for SPIRV-Headers.
Change-Id: I499bbddca76129bdc7061be43a599c1b16cf01e61 parent e31699d commit 1f5193e
1 file changed
+13
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3433 | 3433 | | |
3434 | 3434 | | |
3435 | 3435 | | |
3436 | | - | |
3437 | | - | |
3438 | | - | |
3439 | | - | |
| 3436 | + | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
| 3441 | + | |
3440 | 3442 | | |
3441 | | - | |
3442 | | - | |
3443 | | - | |
| 3443 | + | |
| 3444 | + | |
| 3445 | + | |
| 3446 | + | |
| 3447 | + | |
3444 | 3448 | | |
3445 | 3449 | | |
3446 | 3450 | | |
| |||
3450 | 3454 | | |
3451 | 3455 | | |
3452 | 3456 | | |
| 3457 | + | |
| 3458 | + | |
3453 | 3459 | | |
3454 | 3460 | | |
3455 | 3461 | | |
| |||
0 commit comments