Skip to content

Commit 0d6e06d

Browse files
Anton Sidorenkoigcbot
authored andcommitted
Add comments on passes order.
Add a few comments to justify the order of APL, GEPLowering and TPM.
1 parent cef01ab commit 0d6e06d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

IGC/VectorCompiler/lib/GenXCodeGen/GenXTargetMachine.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,11 @@ bool GenXTargetMachine::addPassesToEmitFile(PassManagerBase &PM,
373373
vc::addPass(PM, createGenXAggregatePseudoLoweringPass());
374374

375375
/// .. include:: GenXGEPLowering.cpp
376+
/// GenXGEPLowering must be run before GenXThreadPrivateMemory and cannot be
377+
/// run earlier as GenXAggregatePseudoLowering may create GEPs.
378+
/// TODO: We run GenXGEPLowering twice: before GenXThreadPrivateMemory and
379+
/// before GenXLowering. It seems that after GenXThreadPrivateMemory removal
380+
/// we can remove this run of GenXGEPLowering.
376381
vc::addPass(PM, createGenXGEPLoweringPass());
377382
/// .. include:: GenXLoadStoreLowering.cpp
378383
vc::addPass(PM, createGenXLoadStoreLoweringPass());

0 commit comments

Comments
 (0)