simple tests

Author: byrnedj

cachelib/allocator/tests/AllocatorMemoryTiersTest.cpp

@@ -26,6 +26,7 @@ using LruAllocatorMemoryTiersTest = AllocatorMemoryTiersTest<LruAllocator>;
 TEST_F(LruAllocatorMemoryTiersTest, MultiTiersFromFileInvalid) { this->testMultiTiersFormFileInvalid(); }
 TEST_F(LruAllocatorMemoryTiersTest, MultiTiersFromFileValid) { this->testMultiTiersFromFileValid(); }
 TEST_F(LruAllocatorMemoryTiersTest, MultiTiersValidMixed) { this->testMultiTiersValidMixed(); }
+TEST_F(LruAllocatorMemoryTiersTest, MultiTiersBackgroundMovers ) { this->testMultiTiersBackgroundMovers(); }
 TEST_F(LruAllocatorMemoryTiersTest, MultiTiersNumaBindingsSysVValid) { this->testMultiTiersNumaBindingsSysVValid(); }
 TEST_F(LruAllocatorMemoryTiersTest, MultiTiersNumaBindingsPosixValid) { this->testMultiTiersNumaBindingsPosixValid(); }
 

cachelib/allocator/tests/AllocatorMemoryTiersTest.h

@@ -19,6 +19,8 @@
 #include "cachelib/allocator/CacheAllocatorConfig.h"
 #include "cachelib/allocator/MemoryTierCacheConfig.h"
 #include "cachelib/allocator/tests/TestBase.h"
+#include "cachelib/allocator/FreeThresholdStrategy.h"
+#include "cachelib/allocator/PromotionStrategy.h"
 
 namespace facebook {
 namespace cachelib {
@@ -62,6 +64,58 @@ class AllocatorMemoryTiersTest : public AllocatorTest<AllocatorT> {
     ASSERT(handle != nullptr);
     ASSERT_NO_THROW(alloc->insertOrReplace(handle));
   }
+  
+  void testMultiTiersBackgroundMovers() {
+    typename AllocatorT::Config config;
+    config.setCacheSize(4 * Slab::kSize);
+    config.enableCachePersistence("/tmp");
+    config.usePosixForShm();
+    config.configureMemoryTiers({
+        MemoryTierCacheConfig::fromShm()
+            .setRatio(1),
+        MemoryTierCacheConfig::fromFile("/tmp/b" + std::to_string(::getpid()))
+            .setRatio(1)
+    });
+    config.enableBackgroundEvictor(std::make_shared<FreeThresholdStrategy>(10, 20, 4, 2),
+            std::chrono::milliseconds(10),1);
+    config.enableBackgroundPromoter(std::make_shared<PromotionStrategy>(5, 4, 2),
+            std::chrono::milliseconds(10),1);
+
+    auto allocator = std::make_unique<AllocatorT>(AllocatorT::SharedMemNew, config);
+    ASSERT(allocator != nullptr);
+
+    const size_t numBytes = allocator->getCacheMemoryStats().cacheSize;
+    const size_t kItemSize = 100;
+    auto poolId = allocator->addPool("default", numBytes);
+
+    const int numItems = 10000;
+    
+    int numAllocatedItems = 0;
+    for (unsigned int i = 0; i < numItems; i++) {
+      auto handle = util::allocateAccessible(
+          *allocator, poolId, folly::to<std::string>(i), kItemSize, 0);
+      ++numAllocatedItems;
+    }
+
+    ASSERT_GT(numAllocatedItems, 0);
+
+    const unsigned int keyLen = 100;
+    const unsigned int nSizes = 10;
+    const auto sizes =
+        this->getValidAllocSizes(*allocator, poolId, nSizes, keyLen);
+    this->fillUpPoolUntilEvictions(*allocator, poolId, sizes, keyLen);
+
+    auto stats = allocator->getGlobalCacheStats();
+    auto perclassEstats = allocator->getBackgroundMoverClassStats(MoverDir::Evict);
+    auto perclassPstats = allocator->getBackgroundMoverClassStats(MoverDir::Promote);
+
+    EXPECT_GT(1, stats.evictionStats.numMovedItems);
+    EXPECT_GT(1, stats.promotionStats.numMovedItems);
+   
+    auto cid = 2;
+    EXPECT_GT(1, perclassEstats[0][0][cid]);
+    EXPECT_GT(1, perclassPstats[1][0][cid]);
+  }
 
   void testMultiTiersValidMixed() {
     typename AllocatorT::Config config;