Skip to content

Commit 27f32ca

Browse files
Jiayue Baofacebook-github-bot
authored andcommitted
Fix ObjectSizeTrackingWithMutation unit test
Summary: The vector test failed opt mode starting today; it can still pass dbg and dev mode though https://www.internalfb.com/intern/test/562950043592554/. Very likely it's because opt mode did certain optimization these days. Reviewed By: therealgymmy Differential Revision: D48359277 fbshipit-source-id: 5e7b1d0573b90c5a58febe0822644d227382b637
1 parent fa33417 commit 27f32ca

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cachelib/experimental/objcache2/tests/ObjectCacheTest.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
#include <folly/Benchmark.h>
1718
#include <folly/Random.h>
1819
#include <gtest/gtest.h>
1920

@@ -634,6 +635,7 @@ class ObjectCacheTest : public ::testing::Test {
634635
ThreadMemoryTracker tMemTracker;
635636
auto memUsage1 = tMemTracker.getMemUsageBytes();
636637
auto objectCopy = std::make_unique<T>(*object);
638+
folly::doNotOptimizeAway(objectCopy);
637639
auto memUsage2 = tMemTracker.getMemUsageBytes();
638640

639641
EXPECT_EQ(memUsage2 - memUsage1, objcache.template getObjectSize(object));

0 commit comments

Comments
 (0)