-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
Description
Summary
When hub configuration files are modified in a PR that also touches target data, validate_target_pr() should warn maintainers, similar to what was implemented for validate_pr() in #292.
Details
Changes to the following config files could affect target data validation:
tasks.json- affects task ID values, output types, roundstarget-data.json- affects target data schema and validation rules
Implementation
The infrastructure is already in place:
capture_validation_warning()for creating structured warningscheck_pr_config_modified()helper function (may need minor adjustment for target-specific messaging)combine.target_validations()already merges warnings attributesprint.hub_validations()(inherited bytarget_validations) displays warnings
Just need to add the check_pr_config_modified() call to validate_target_pr() and attach the warning.
Priority
Low - can wait for broader hub integrity check work (#83). This is a stopgap measure; long-term solution will involve more comprehensive integrity checking.
Related
- Add warning when config files are modified in PR validation #292 - Config modification warning for
validate_pr() - Function and action that scans and reports on the “health/integrity” of a repo periodically #83 - Hub integrity/health check functionality
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Todo