Skip to content

Add config modification warning to validate_target_pr() #298

@annakrystalli

Description

@annakrystalli

Summary

When hub configuration files are modified in a PR that also touches target data, validate_target_pr() should warn maintainers, similar to what was implemented for validate_pr() in #292.

Details

Changes to the following config files could affect target data validation:

  • tasks.json - affects task ID values, output types, rounds
  • target-data.json - affects target data schema and validation rules

Implementation

The infrastructure is already in place:

  • capture_validation_warning() for creating structured warnings
  • check_pr_config_modified() helper function (may need minor adjustment for target-specific messaging)
  • combine.target_validations() already merges warnings attributes
  • print.hub_validations() (inherited by target_validations) displays warnings

Just need to add the check_pr_config_modified() call to validate_target_pr() and attach the warning.

Priority

Low - can wait for broader hub integrity check work (#83). This is a stopgap measure; long-term solution will involve more comprehensive integrity checking.

Related

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions