Skip to content

Commit 8c632c2

Browse files
committed
Remove WRITE_TRUNCATE option when writing to BQ.
1 parent 1b25caf commit 8c632c2

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

docker/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ RUN apt-get update && apt-get install -y \
4747
zlib1g-dev
4848

4949
# Install dependencies.
50+
51+
5052
RUN python -m pip install --upgrade pip && \
5153
python -m pip install --upgrade virtualenv && \
5254
virtualenv /opt/gcp_variant_transforms/venv && \

gcp_variant_transforms/transforms/sample_info_to_bigquery.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,11 @@ def __init__(self, output_table_prefix, sample_name_encoding, append=False):
7373
def expand(self, pcoll):
7474
return (pcoll
7575
| 'ConvertSampleInfoToBigQueryTableRow' >> beam.ParDo(
76-
ConvertSampleInfoToRow(self._sample_name_encoding))
77-
| 'WriteSampleInfoToBigQuery' >> beam.io.Write(beam.io.BigQuerySink(
76+
ConvertSampleInfoToRow(self.sample_name_encoding))
77+
| 'WriteSampleInfoToBigQuery' >> beam.io.WriteToBigQuery(
7878
self._output_table,
7979
schema=self._schema,
8080
create_disposition=(
8181
beam.io.BigQueryDisposition.CREATE_IF_NEEDED),
82-
write_disposition=(
83-
beam.io.BigQueryDisposition.WRITE_APPEND
84-
if self._append
85-
else beam.io.BigQueryDisposition.WRITE_TRUNCATE),
82+
write_disposition=beam.io.BigQueryDisposition.WRITE_APPEND,
8683
method=beam.io.WriteToBigQuery.Method.FILE_LOADS))

gcp_variant_transforms/transforms/variant_to_bigquery.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,5 @@ def expand(self, pcoll):
115115
schema=self._schema,
116116
create_disposition=(
117117
beam.io.BigQueryDisposition.CREATE_IF_NEEDED),
118-
write_disposition=(
119-
beam.io.BigQueryDisposition.WRITE_APPEND
120-
if self._append
121-
else beam.io.BigQueryDisposition.WRITE_TRUNCATE),
118+
write_disposition=beam.io.BigQueryDisposition.WRITE_APPEND,
122119
method=beam.io.WriteToBigQuery.Method.FILE_LOADS))

gcp_variant_transforms/vcf_to_bq.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,6 @@ def run(argv=None):
483483
num_shards = 1
484484

485485
if known_args.output_table:
486-
<<<<<<< HEAD
487-
<<<<<<< HEAD
488486
schema_file = tempfile.mkstemp(prefix=known_args.output_table,
489487
suffix=_BQ_SCHEMA_FILE_SUFFIX)[1]
490488
schema = (

0 commit comments

Comments
 (0)