net/http/httptest: remove unnecessary creation of http.Transport

ZekeLu · neild · commit f5ec2e46d93f · 2023-11-06T21:16:01.000Z
In (*Server).StartTLS, it's unnecessary to create an http.Client with a Transport, because a new one will be created with the TLSClientConfig later. Change-Id: I086e28717e9739787529006c3f0296c8224cd790 GitHub-Last-Rev: 3372459 GitHub-Pull-Request: golang#60124 Reviewed-on: https://go-review.googlesource.com/c/go/+/494355 Run-TryBot: t hepudds <thepudds1460@gmail.com> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com>
diff --git a/src/net/http/httptest/server.go b/src/net/http/httptest/server.go
@@ -144,7 +144,7 @@ func (s *Server) StartTLS() {
 		panic("Server already started")
 	}
 	if s.client == nil {
-		s.client = &http.Client{Transport: &http.Transport{}}
+		s.client = &http.Client{}
 	}
 	cert, err := tls.X509KeyPair(testcert.LocalhostCert, testcert.LocalhostKey)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func (s *Server) StartTLS() {`
`144`	`144`	`panic("Server already started")`
`145`	`145`	`}`
`146`	`146`	`if s.client == nil {`
`147`		`- s.client = &http.Client{Transport: &http.Transport{}}`
	`147`	`+ s.client = &http.Client{}`
`148`	`148`	`}`
`149`	`149`	`cert, err := tls.X509KeyPair(testcert.LocalhostCert, testcert.LocalhostKey)`
`150`	`150`	`if err != nil {`