Skip to content

Filter conflicting global constants #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashtonmeuser wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −2
Open

Filter conflicting global constants #1916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
439d89d
Filter conflicting global constants
ashtonmeuser Jan 31, 2026
496e5a2
Fix ruff format diff
ashtonmeuser Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions binding_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2259,8 +2259,24 @@ def generate_global_constants(api, output_dir):
header.append("namespace godot {")
header.append("")

if len(api["global_constants"]) > 0:
for constant in api["global_constants"]:
# Remove integer limit global constants that overlap with those defined in cstdint
limit_constants = {
"UINT8_MAX",
"UINT16_MAX",
"UINT32_MAX",
"INT8_MIN",
"INT8_MAX",
"INT16_MIN",
"INT16_MAX",
"INT32_MIN",
"INT32_MAX",
"INT64_MIN",
"INT64_MAX",
}
global_constants = [c for c in api["global_constants"] if c["name"] not in limit_constants]

if len(global_constants) > 0:
for constant in global_constants:
header.append(f"const int64_t {escape_identifier(constant['name'])} = {constant['value']};")

header.append("")
Expand Down