From b41bafba3428e1b9b23556b47d5064dd8c97f80c Mon Sep 17 00:00:00 2001
From: pedrocaseiro <pcaseiro96@gmail.com>
Date: Mon, 30 Oct 2017 21:52:50 +0000
Subject: [PATCH 1/2] iframe without scroll

---
 README.md    |  1 +
 example.html |  2 ++
 index.js     | 14 ++++++++++++++
 test/test.js | 14 ++++++++++++++
 4 files changed, 31 insertions(+)

diff --git a/README.md b/README.md
index 6fe8f05..8d6f65f 100644
--- a/README.md
+++ b/README.md
@@ -34,6 +34,7 @@ List of errors:
 - `InputMissingLabelError`
 - `ButtonWithoutLabelError`
 - `ARIAAttributeMissingError`
+- `IframeWithoutScroll`
 
 ## Scenario
 
diff --git a/example.html b/example.html
index baef074..38e8785 100644
--- a/example.html
+++ b/example.html
@@ -42,6 +42,8 @@
       <a>Link</a>
       <p>Image without alt</p>
       <img src="https://github.com/octocat.png" width="50" height="50">
+      <p>iframe without scroll</p>
+      <iframe src='example.html' scrolling="no"></iframe>
     </div>
 
     <script type="text/javascript">
diff --git a/index.js b/index.js
index 32121f5..afea5f6 100644
--- a/index.js
+++ b/index.js
@@ -38,6 +38,12 @@ export function scanForProblems(context, logError, options) {
       logError(new InputMissingLabelError(input))
     }
   }
+
+  for (const iframe of context.querySelectorAll('iframe')) {
+    if (iframe.hasAttribute('scrolling') && iframe.getAttribute('scrolling') === 'no') {
+      logError(new IframeWithoutScroll(iframe))
+    }
+  }
   if (options && options['ariaPairs']) {
     for (const selector in options['ariaPairs']) {
       const ARIAAttrsRequired =  options['ariaPairs'][selector]
@@ -117,6 +123,14 @@ function ARIAAttributeMissingError(element, attr) {
 }
 errorSubclass(ARIAAttributeMissingError)
 
+function IframeWithoutScroll(element) {
+  this.name = 'IframeWithoutScroll'
+  this.stack = new Error().stack
+  this.element = element
+  this.message = `Frame missing scroll on ${inspect(element)}`
+}
+errorSubclass(IframeWithoutScroll)
+
 function elementIsHidden(element) {
   return element.closest('[aria-hidden="true"], [hidden], [style*="display: none"]') != null
 }
diff --git a/test/test.js b/test/test.js
index 45fe096..d8a4769 100644
--- a/test/test.js
+++ b/test/test.js
@@ -41,6 +41,13 @@ describe('scanForProblems should catch', () => {
 
     assert.equal(button.getAttribute('data-error'), 'ARIAAttributeMissingError')
   })
+
+  it('iframe without scroll', () => {
+    const iframe = makeElement('iframe', {"scrolling": "no"})
+    document.body.appendChild(iframe)
+
+    assert.equal(iframe.getAttribute('data-error'), 'IframeWithoutScroll')
+  })
 })
 
 describe('scanForProblems should not catch', () => {
@@ -83,6 +90,13 @@ describe('scanForProblems should not catch', () => {
     assert.notOk(label.getAttribute('data-error'))
     assert.notOk(input.getAttribute('data-error'))
   })
+
+  it('iframe with scroll', () => {
+    const iframe = makeElement('iframe')
+    document.body.appendChild(iframe)
+
+    assert.notOk(iframe.getAttribute('data-error'))
+  })
 })
 
 function makeElement(tag, attributes, content) {

From b6b56b0f6679d47a530435353b1829f6d5615501 Mon Sep 17 00:00:00 2001
From: pedrocaseiro <pcaseiro96@gmail.com>
Date: Mon, 30 Oct 2017 21:54:19 +0000
Subject: [PATCH 2/2] fix typo

---
 index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.js b/index.js
index afea5f6..2d2f090 100644
--- a/index.js
+++ b/index.js
@@ -127,7 +127,7 @@ function IframeWithoutScroll(element) {
   this.name = 'IframeWithoutScroll'
   this.stack = new Error().stack
   this.element = element
-  this.message = `Frame missing scroll on ${inspect(element)}`
+  this.message = `iframe missing scroll on ${inspect(element)}`
 }
 errorSubclass(IframeWithoutScroll)