refactor: enhance type safety and improve code clarity in AI analysis and viewport components

Author: gitcoder89431

src/lib/components/panels/Viewport.svelte

@@ -1,11 +1,13 @@
-<script>
+<script lang="ts">
 	import { onMount } from 'svelte';
 	import { selectedPetStore, petHelpers, selectedPetHelpers } from '$lib/stores/pets';
 	import { aiAnalysisHelpers, isAnalyzing } from '$lib/stores/ai-analysis';
 	import { PenTool, Brain, Calendar, Heart, Activity } from 'lucide-svelte';
 	import AIInsightsCard from '../ui/AIInsightsCard.svelte';
+	import type { PetPanelData } from '$lib/types/Pet';
+	import type { JournalEntry } from '$lib/types/JournalEntry';
 
-	let selectedPet = null;
+	let selectedPet: PetPanelData | null = null;
 	let currentView = 'dashboard'; // dashboard, journal, history
 	let journalInput = '';
 	let selectedMood = '';
@@ -28,13 +30,17 @@
 		isSubmitting = true;
 
 		try {
-			const entry = {
+			const now = new Date();
+			const entry: JournalEntry = {
 				id: Date.now().toString(),
 				petId: selectedPet.id,
+				type: 'general',
+				title: `Journal Entry - ${now.toLocaleDateString()}`,
 				content: journalInput.trim(),
-				date: new Date().toISOString(),
-				mood: selectedMood || 'unknown',
-				activityLevel: selectedActivity || 'normal',
+				date: now,
+				mood: (selectedMood as JournalEntry['mood']) || 'neutral',
+				createdAt: now,
+				updatedAt: now,
 			};
 
 			// Add entry to pet

src/lib/components/ui/AIInsightsCard.svelte

@@ -1,12 +1,14 @@
-<script>
+<script lang="ts">
 	import { Brain, AlertTriangle, CheckCircle, TrendingUp } from 'lucide-svelte';
 	import { aiAnalysisHelpers } from '$lib/stores/ai-analysis';
+	import type { AnalysisResult } from '$lib/utils/ai-analysis';
 
 	export let entryId = '';
-	export const petId = '';
+	// eslint-disable-next-line svelte/valid-compile
+	export let petId = '';
 	export let compact = false;
 
-	let analysis = null;
+	let analysis: AnalysisResult | null = null;
 
 	$: if (entryId) {
 		analysis = aiAnalysisHelpers.getAnalysis(entryId);

src/lib/stores/ai-analysis.ts

@@ -1,7 +1,7 @@
 import { writable } from 'svelte/store';
 import { AIAnalyzer, type AnalysisResult } from '$lib/utils/ai-analysis';
 import { guardianStore } from './guardian';
-import type { Pet } from '../types/Pet';
+import type { PetPanelData } from '../types/Pet';
 import type { JournalEntry } from '../types/JournalEntry';
 
 export const analysisStore = writable<Record<string, AnalysisResult>>({});
@@ -19,7 +19,7 @@ guardianStore.subscribe((guardian) => {
 });
 
 export const aiAnalysisHelpers = {
-	async analyzeEntry(pet: Pet, entry: JournalEntry): Promise<AnalysisResult | null> {
+	async analyzeEntry(pet: PetPanelData, entry: JournalEntry): Promise<AnalysisResult | null> {
 		if (!analyzer) {
 			throw new Error('API key not configured');
 		}

src/lib/utils/ai-analysis.ts

@@ -1,4 +1,4 @@
-import type { Pet } from '../types/Pet.js';
+import type { PetPanelData } from '../types/Pet.js';
 import type { JournalEntry } from '../types/JournalEntry.js';
 
 export interface AnalysisResult {
@@ -18,7 +18,7 @@ export class AIAnalyzer {
 		this.apiKey = apiKey;
 	}
 
-	async analyzeJournalEntry(pet: Pet, entry: JournalEntry): Promise<AnalysisResult> {
+	async analyzeJournalEntry(pet: PetPanelData, entry: JournalEntry): Promise<AnalysisResult> {
 		const prompt = this.buildAnalysisPrompt(pet, entry);
 
 		try {
@@ -60,24 +60,24 @@ export class AIAnalyzer {
 		}
 	}
 
-	private buildAnalysisPrompt(pet: Pet, entry: JournalEntry): string {
+	private buildAnalysisPrompt(pet: PetPanelData, entry: JournalEntry): string {
 		const recentEntries =
 			pet.journalEntries
 				?.slice(-5)
-				.map((e: JournalEntry) => `${e.date}: ${e.content}`)
+				.map((e) => `${e.date}: ${e.content}`)
 				.join('\n') || 'No previous entries available';
 
 		return `
-Analyze this journal entry for ${pet.name}, a ${pet.age || 'unknown age'}-year-old ${pet.breed || pet.species}:
+Analyze this journal entry for ${pet.name}, a ${pet.age || 'unknown age'}-year-old ${pet.breed}:
 
 LATEST ENTRY: "${entry.content}"
 
 RECENT HISTORY:
 ${recentEntries}
 
 PET INFO:
-- Breed: ${pet.breed || pet.species}
-- Age: ${pet.age || 'unknown'} years  
+- Breed: ${pet.breed}
+- Age: ${pet.age || 'unknown'} years
 - Gender: ${pet.gender || 'unknown'}
 
 Please provide analysis in this JSON format: