Allow all quantities multiplication by float | Percentage

This is only applying a factor so it should be safe for any Quantity.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>

Author: llucax

src/frequenz/sdk/timeseries/_quantities.py

@@ -970,6 +970,23 @@ def as_megawatt_hours(self) -> float:
         """
         return self._base_value / 1e6
 
+    def __mul__(self, other: float | Percentage) -> Self:
+        """Scale this energy by a percentage.
+
+        Args:
+            other: The percentage by which to scale this energy.
+
+        Returns:
+            The scaled energy.
+        """
+        match other:
+            case float():
+                return self._new(self._base_value * other)
+            case Percentage():
+                return self._new(self._base_value * other.as_fraction())
+            case _:
+                return NotImplemented
+
     @overload
     def __truediv__(self, other: timedelta) -> Power:
         """Return a power from dividing this energy by the given duration.

tests/timeseries/test_quantities.py

@@ -592,11 +592,12 @@ def test_invalid_multiplications() -> None:
         with pytest.raises(TypeError):
             energy *= quantity  # type: ignore
 
-    for quantity in [power, voltage, current, energy, Percentage.from_percent(50)]:
-        with pytest.raises(TypeError):
-            _ = quantity * 200.0  # type: ignore
-        with pytest.raises(TypeError):
-            quantity *= 200.0  # type: ignore
+# __mod__
+#    for quantity in [power, voltage, current, energy, Percentage.from_percent(50)]:
+#        with pytest.raises(TypeError):
+#            _ = quantity * 200.0  # type: ignore
+#        with pytest.raises(TypeError):
+#            quantity *= 200.0  # type: ignore
 
 
 # We can't use _QUANTITY_TYPES here, because it will break the tests, as hypothesis