Skip to content

Commit 9b1cb03

Browse files
committed
Remove prettier from "test" script and github workflow check.
1 parent e691bf9 commit 9b1cb03

File tree

3 files changed

+2
-32
lines changed

3 files changed

+2
-32
lines changed

.github/workflows/checks.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -3,36 +3,6 @@ name: Code checks
33
on: [pull_request]
44

55
jobs:
6-
prettier:
7-
runs-on: ubuntu-latest
8-
9-
strategy:
10-
matrix:
11-
node-version: [16.x]
12-
13-
steps:
14-
- name: Checkout commit
15-
uses: actions/checkout@v2
16-
17-
- name: Use Node.js ${{ matrix.node-version }}
18-
uses: actions/setup-node@v2
19-
with:
20-
node-version: ${{ matrix.node-version }}
21-
22-
- name: Cache NPM
23-
uses: actions/cache@v2
24-
with:
25-
path: ~/.npm
26-
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
27-
restore-keys: |
28-
${{ runner.os }}-node-
29-
30-
- name: Install packages
31-
run: npm ci
32-
33-
- name: Run Prettier
34-
run: npm run prettier
35-
366
lint:
377
runs-on: ubuntu-latest
388

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Runs `tsc --noEmit`, which will compile the TypeScript code without emitting fil
9494

9595
## Husky
9696

97-
This project uses [Husky](https://typicode.github.io/husky/#/) to check code on git commits. By default, it is setup to use the `npm test` script which runs `lint`, `prettier`, and `tsc` (TypeScript) checks against the codebase. This check occurs on `git commit` attempts. This helps developers catch errors _before_ pushing branches and creating PRs, quickening the overall dev worklow.
97+
This project uses [Husky](https://typicode.github.io/husky/#/) to check code on git commits. By default, it is setup to use the `npm test` script which runs `lint` and `tsc` (TypeScript) checks against the codebase. This check occurs on `git commit` attempts. This helps developers catch errors _before_ pushing branches and creating PRs, quickening the overall dev worklow.
9898

9999
To bypass this check, you can use the `--no-verify` flag with your commit:
100100

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"prettier": "prettier --check pages/ source/",
1212
"prettier:write": "prettier --write pages/ source/",
1313
"tsc": "tsc --noEmit",
14-
"test": "npm run lint && npm run prettier && npm run tsc",
14+
"test": "npm run lint && npm run tsc",
1515
"prepare": "husky install"
1616
},
1717
"dependencies": {

0 commit comments

Comments
 (0)