-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Labels
effort:mediumMedium effort needed to implement/fixMedium effort needed to implement/fixenhancementNew feature or requestNew feature or requestfcli-fodIssue related to 'fcli fod' commandsIssue related to 'fcli fod' commands
Description
Enhancement Request
Replace ad-hoc display/value handling in InProgressScanActionType with the shared resolver (IFoDEnumValueSupplier.resolveEnumValue(...)) to eliminate duplication, improve input matching robustness, and make enum behavior consistent across FoD enums.
Other potential useful refactors for maintainability:
- Extract large
FoDEnums.javainto multiple top-level enum classes (one file per related enum or per domain), e.g.:InProgressScanActionType.javaDeveloperStatusType.javaAuditorStatusType.javaTimeZones.java
This improves navigability and reduces merge conflicts.
- Standardize enum APIs:
- Use consistent method names:
getValue()for the canonical display string, orgetDisplayName()where appropriate. - For enums representing external IDs, consistently expose
getId()orgetInternalValue()(instead of mixed_val,fodInternalValue, etc.).
- Use consistent method names:
- Introduce additional generic helpers:
IFoDEnumValueSupplieralready covers string/display resolution—consider addingIFoDEnumIntSupplierfor enums that map to ints (to centralizefromIntpatterns). - Convert enums that use
toString()custom logic to expose explicitgetDisplay()and keeptoString()either delegating togetDisplay()or left default with clear Javadoc. - Add focused unit tests for each enum's parsing/resolution behavior (name->value, display->value, invalid inputs).
Lint/format and add Javadoc for each enum explaining intended external representation and matching rules. - Replace ad-hoc switch-based
fromIntwith small reusable helpers where it makes sense (but avoid over-abstracting simple cases).
Metadata
Metadata
Assignees
Labels
effort:mediumMedium effort needed to implement/fixMedium effort needed to implement/fixenhancementNew feature or requestNew feature or requestfcli-fodIssue related to 'fcli fod' commandsIssue related to 'fcli fod' commands