Updating imported files in imported files does not compile

[AntonTrollback]

I have a master file importing a setup file. The setup file then imports a set of module files.

If I edit the module files, nothing compiles. But altering the setup or the master files runs the compiler correctly.

[lucasmazza]

If I got it correctly, the ImportProcessor doesn't track the dependencies recursively. Could you work on a patch for that?

[AntonTrollback]

Sorry I'm not up for the task since I have no knowledge in ruby.

[lucasmazza]

I'll work on something later then. Meanwhile, you can use the depend_on directive to explicity list your dependencies between files.

Your master file:

//= depend_on 'module'
@import 'setup'

And your setup file:

@import 'module'

[lucasmazza]

@AntonTrollback I pushed some changes, can you take the master branch for a spin in your app? Just drop something like this on your Gemfile and update your app to use stylus directly from master.

gem 'stylus', :github => 'lucasmazza/ruby-stylus'

Thanks!

[roblafeve]

@lucasmazza Has this been resolved? I'm still having the same issue running the above release.

To clarify— I have an application.css.styl file that has:

@import 'category/resource/index'
@import 'category/module/index'
@import 'category/layout/index'

Whenever I alter a file down the tree, the change doesn't compile. If I alter application.css.styl and save, it then compiles changes down the tree that I had made.

[lucasmazza]

@roblafeve can you provide a sample app that replicates the issue?

[roblafeve]

Sure thing— https://github.com/roblafeve/ruby-stylus-compiler-bug

I have an application.css.styl that imports an index file in a sub-directory, that imports another file.

[lucasmazza]

@roblafeve thanks! I've found that my solution on b787c65 doesn't work with assets in different folder levels - since Sprockets don't understand the relative import in layout/index to layout/header. If everything is in the same folder/level (like app/assets/stylesheets and/or lib/assets/stylesheets) it work as expected.

If your dependency hierarchy doesn't share variables between the stylesheets I strongly suggest that you use Sprockets directives instead of @import. I'm gonna dig into this to check if there's a decent way to handle these different paths between Stylus and Sprockets. Thanks for the report.

[roblafeve]

Thanks! I really appreciate your help on this. I'll try using the sprockets for now.

[rschmukler]

@lucasmazza Any recommendations for shared variable spaces? My structure is a little more complex....

app/assets/stylesheets/application.css:

 *= require_self
 *= require stylized_application
 *= require sassy_application

This lets me use some sass stylesheets from older days, and then stylized_application imports various global things, as well as compartmentalized styl files...

app/assets/stylesheets/stylized_application.css.styl

@import 'definitions'
@import 'mixins'
 ...
@import 'contests'

In this case, contests is actually a folder which makes use of Stylus' index.styl support for @import

Which means leaves me with:

app/assets/stylsheets/contests/index.styl

@import 'prizes'
@import 'image_contest'
@import 'song_contest'
...

So then when app/assets/stylesheets/contests/index.styl changes, the changes are propagated correctly (including any changes made in dependencies of contests/index.styl. However, if I change app/assets/stylesheets/contests/prizes.styl without changing contests/index.styl the changes are not carried over.

Any ideas?

[rschmukler]

Looked through the source a little bit, seems like it wont be too bad of an extension to get it to load files references by index.styl, so I may try and implement this tonight (just forked).

[rschmukler]

It's worth noting that this change goes doesn't quite fix my @imports as you must use the path relative to app/assets/stylesheets, as opposed to the relative path like I was using... Unfortunately, I don't have much of a solution for it, and its really not a big hassle to have to type the full path