More error metrics (#635)

## 📝 Summary

Adds 2 metrics:
* coinbase balance
* rpc errors counters

## 💡 Motivation and Context

<!--- (Optional) Why is this change required? What problem does it
solve? Remove this section if not applicable. -->

---

## ✅ I have completed the following steps:

* [ ] Run `make lint`
* [ ] Run `make test`
* [ ] Added tests (if applicable)

Author: dvush

crates/rbuilder/src/live_builder/block_output/bidding/wallet_balance_watcher.rs

@@ -7,7 +7,7 @@ use tracing::{error, info, warn};
 
 use super::interfaces::LandedBlockInfo;
 use crate::provider::StateProviderFactory;
-use crate::telemetry::{add_subsidy_value, inc_subsidized_blocks};
+use crate::telemetry::{add_subsidy_value, inc_subsidized_blocks, set_builder_balance};
 
 /// Allows to monitor the evolution of our wallet for the landed blocks.
 /// It's useful for bidders to detect profit and subsidies.
@@ -169,6 +169,7 @@ where
             }
             self.balance = landed_block_info.builder_balance;
             self.block_number = landed_block_info.block_number;
+            set_builder_balance(self.balance);
         }
         Ok(res)
     }

crates/rbuilder/src/live_builder/order_input/rpc_server.rs

@@ -7,7 +7,10 @@ use crate::{
         },
         BundleReplacementData, BundleReplacementKey, MempoolTx, Order, OrderId,
     },
-    telemetry::{add_rpc_processing_time, mark_command_received, scope_meter::ScopeMeter},
+    telemetry::{
+        add_rpc_processing_time, inc_order_input_rpc_errors, mark_command_received,
+        scope_meter::ScopeMeter,
+    },
 };
 use alloy_primitives::{Address, Bytes};
 use jsonrpsee::{
@@ -31,6 +34,11 @@ use tokio_util::sync::CancellationToken;
 use tracing::{info, trace, warn};
 use uuid::Uuid;
 
+const ETH_SEND_BUNDLE: &str = "eth_sendBundle";
+const MEV_SEND_BUNDLE: &str = "mev_sendBundle";
+const ETH_CANCEL_BUNDLE: &str = "eth_cancelBundle";
+const ETH_SEND_RAW_TRANSACTION: &str = "eth_sendRawTransaction";
+
 /// Adds metrics to the callback and registers via module.register_async_method.
 pub fn register_metered_async_method<'a, R, Fun, Fut>(
     module: &'a mut RpcModule<()>,
@@ -74,22 +82,22 @@ pub async fn start_server_accepting_bundles(
     let mut module = RpcModule::new(());
 
     let results_clone = results.clone();
-    register_metered_async_method(&mut module, "eth_sendBundle", move |params, _| {
+    register_metered_async_method(&mut module, ETH_SEND_BUNDLE, move |params, _| {
         handle_eth_send_bundle(results_clone.clone(), timeout, params)
     })?;
 
     let results_clone = results.clone();
-    register_metered_async_method(&mut module, "mev_sendBundle", move |params, _| {
+    register_metered_async_method(&mut module, MEV_SEND_BUNDLE, move |params, _| {
         handle_mev_send_bundle(results_clone.clone(), timeout, params)
     })?;
 
     let results_clone = results.clone();
-    register_metered_async_method(&mut module, "eth_cancelBundle", move |params, _| {
+    register_metered_async_method(&mut module, ETH_CANCEL_BUNDLE, move |params, _| {
         handle_cancel_bundle(results_clone.clone(), timeout, params)
     })?;
 
     let results_clone = results.clone();
-    register_metered_async_method(&mut module, "eth_sendRawTransaction", move |params, _| {
+    register_metered_async_method(&mut module, ETH_SEND_RAW_TRANSACTION, move |params, _| {
         let results = results_clone.clone();
         async move {
             let received_at = OffsetDateTime::now_utc();
@@ -98,7 +106,7 @@ pub async fn start_server_accepting_bundles(
                 Ok(raw_tx) => raw_tx,
                 Err(err) => {
                     warn!(?err, "Failed to parse raw transaction");
-                    // @Metric
+                    inc_order_input_rpc_errors(ETH_SEND_RAW_TRANSACTION);
                     return Err(err);
                 }
             };
@@ -108,7 +116,7 @@ pub async fn start_server_accepting_bundles(
                 Ok(tx) => tx,
                 Err(err) => {
                     warn!(?err, "Failed to decode raw transaction");
-                    // @Metric
+                    inc_order_input_rpc_errors(ETH_SEND_RAW_TRANSACTION);
                     return Err(ErrorObject::owned(
                         -32602,
                         "failed to verify transaction",
@@ -157,7 +165,7 @@ async fn handle_eth_send_bundle(
         Ok(raw_bundle) => raw_bundle,
         Err(err) => {
             warn!(?err, "Failed to parse raw bundle");
-            // @Metric
+            inc_order_input_rpc_errors(ETH_SEND_BUNDLE);
             return;
         }
     };
@@ -170,7 +178,7 @@ async fn handle_eth_send_bundle(
         Ok(bundle_res) => bundle_res,
         Err(err) => {
             warn!(?err, "Failed to decode raw bundle");
-            // @Metric
+            inc_order_input_rpc_errors(ETH_SEND_BUNDLE);
             return;
         }
     };
@@ -185,6 +193,7 @@ async fn handle_eth_send_bundle(
                     max_timestamp = bundle.max_timestamp,
                     "Bundle has timestamp 0"
                 );
+                inc_order_input_rpc_errors(ETH_SEND_BUNDLE);
             }
             let order = Order::Bundle(bundle);
             let parse_duration = start.elapsed();
@@ -218,15 +227,15 @@ async fn handle_mev_send_bundle(
         Ok(raw_bundle) => raw_bundle,
         Err(err) => {
             warn!(?err, "Failed to parse raw share bundle");
-            // @Metric
+            inc_order_input_rpc_errors(MEV_SEND_BUNDLE);
             return;
         }
     };
     let decode_res = match raw_bundle.decode(TxEncoding::WithBlobData) {
         Ok(res) => res,
         Err(err) => {
             warn!(?err, "Failed to decode raw share bundle");
-            // @Metric
+            inc_order_input_rpc_errors(MEV_SEND_BUNDLE);
             return;
         }
     };
@@ -282,6 +291,7 @@ async fn send_command(
         Ok(()) => {}
         Err(SendTimeoutError::Timeout(_)) => {
             warn!("Failed to sent order, timeout");
+            inc_order_input_rpc_errors("other");
         }
         Err(SendTimeoutError::Closed(_)) => {}
     };
@@ -306,7 +316,7 @@ async fn handle_cancel_bundle(
         Ok(cancel_bundle) => cancel_bundle,
         Err(err) => {
             warn!(?err, "Failed to parse cancel bundle");
-            // @Metric
+            inc_order_input_rpc_errors(ETH_CANCEL_BUNDLE);
             return;
         }
     };

crates/rbuilder/src/telemetry/metrics/mod.rs

@@ -12,15 +12,16 @@ use crate::{
     primitives::mev_boost::MevBoostRelayID,
     utils::{build_info::Version, duration_ms},
 };
+use alloy_consensus::constants::GWEI_TO_WEI;
 use alloy_primitives::{utils::Unit, U256};
 use bigdecimal::num_traits::Pow;
 use ctor::ctor;
 use lazy_static::lazy_static;
 use metrics_macros::register_metrics;
 use parking_lot::Mutex;
 use prometheus::{
-    Counter, HistogramOpts, HistogramVec, IntCounter, IntCounterVec, IntGauge, IntGaugeVec, Opts,
-    Registry,
+    Counter, Gauge, HistogramOpts, HistogramVec, IntCounter, IntCounterVec, IntGauge, IntGaugeVec,
+    Opts, Registry,
 };
 use std::{
     sync::Arc,
@@ -126,6 +127,11 @@ register_metrics! {
     )
     .unwrap();
 
+    pub static ORDER_INPUT_RPC_ERROR: IntCounterVec = IntCounterVec::new(
+    Opts::new("rbuilder_order_input_rpc_errors", "counter of errors when receiving orders on RPC"),
+    &["kind"],
+    ).unwrap();
+
     pub static RELAY_ERRORS: IntCounterVec = IntCounterVec::new(
         Opts::new("relay_errors", "counter of relay errors"),
         &["relay", "kind"]
@@ -227,6 +233,8 @@ register_metrics! {
      // SUBSIDY
      /////////////////////////////////
 
+    pub static BUILDER_BALANCE: Gauge = Gauge::new("rbuilder_coinbase_balance", "balance of builder coinbase").unwrap();
+
     /// We decide this at the end of the submission to relays
     pub static SUBSIDIZED_BLOCK_COUNT: IntCounterVec = IntCounterVec::new(
         Opts::new(
@@ -424,6 +432,10 @@ pub fn set_ordepool_count(txs: usize, bundles: usize) {
     ORDERPOOL_BUNDLES.set(bundles as i64);
 }
 
+pub fn inc_order_input_rpc_errors(method: &str) {
+    ORDER_INPUT_RPC_ERROR.with_label_values(&[method]).inc();
+}
+
 #[allow(clippy::too_many_arguments)]
 pub fn add_finalized_block_metrics(
     built_block_trace: &BuiltBlockTrace,
@@ -593,6 +605,13 @@ pub fn add_subsidy_value(value: U256, landed: bool) {
     }
 }
 
+pub fn set_builder_balance(balance: U256) {
+    let gwei_balance = balance / U256::from(GWEI_TO_WEI);
+    let u64_gwei_balance: u64 = gwei_balance.try_into().unwrap_or(0);
+    let f64_eth_balance = u64_gwei_balance as f64 / 1_000_000_000.0;
+    BUILDER_BALANCE.set(f64_eth_balance);
+}
+
 fn sim_status(success: bool) -> &'static str {
     if success {
         SIM_STATUS_OK