Skip to content

Commit 422ff9c

Browse files
hlshenjoehan
andauthored
update vscode to 2.0.0 (#9611)
Co-authored-by: Joe Hanley <joehanley@google.com>
1 parent 43ef1f6 commit 422ff9c

File tree

5 files changed

+11
-17
lines changed

5 files changed

+11
-17
lines changed

firebase-vscode/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
## NEXT
22

3-
- Fixed common code lens rendering issue.
3+
## 2.0.0
4+
5+
- Update internal `firebase-tools` dependency to 15.0.0
6+
- [Fixed] common code lens rendering issue.
47
- Don't show "Generate query" in schema file.
58
- Don't show "Generate query" for comments within an operation.
69
- Show "Add Data" for @table type only.
710
- Show "View Data" for @table and @view type.
11+
- [Fixed] Integration test for recent variables panel changes
812

913
## 1.10.2
1014

firebase-vscode/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

firebase-vscode/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"publisher": "GoogleCloudTools",
55
"icon": "./resources/firebase_dataconnect_logo.png",
66
"description": "Firebase Data Connect for VSCode",
7-
"version": "1.10.2",
7+
"version": "2.0.0",
88
"engines": {
99
"vscode": "^1.69.0"
1010
},

firebase-vscode/src/test/integration/fishfood/exeuction-missing-variables.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { mockUser } from "../../utils/user";
1212
import { Notifications } from "../../utils/page_objects/notifications";
1313

1414
firebaseSuite("Execution", async function () {
15-
firebaseTest("should ask user to add missing variables", async function () {
15+
firebaseTest("should auto add missing variables", async function () {
1616
const workbench = await browser.getWorkbench();
1717

1818
const sidebar = new FirebaseSidebar(workbench);
@@ -40,18 +40,8 @@ firebaseSuite("Execution", async function () {
4040
await editor.openFile(mutationsPath);
4141
await editor.runLocalButton.waitForDisplayed();
4242
await editor.runLocalButton.click();
43-
44-
const editVariablesNotif = await notification.getEditVariablesNotification();
4543

46-
if (!editVariablesNotif) {
47-
throw(new Error("Edit Variables Notification not found"));
48-
}
49-
await notification.editVariablesFromNotification(editVariablesNotif);
50-
51-
expect(await execution.getVariables()).toEqual(`{"id":"42","content":""}`);
52-
53-
// click re-run button to continue
54-
await execution.clickRerun();
44+
expect(JSON.parse((await execution.getVariables()))).toEqual({"id":"42","content":""});
5545

5646
async function getExecutionStatus() {
5747
let item = await execution.history.getSelectedItem();

firebase-vscode/src/test/utils/page_objects/execution.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class ExecutionPanel {
4040
async runInConfigurationContext<R>(
4141
cb: (configs: ConfigurationView) => Promise<R>,
4242
): Promise<R> {
43-
const [a, b] = await findWebviewWithTitle("Configuration");
43+
const [a, b] = await findWebviewWithTitle("Parameters");
4444

4545
return runInFrame(a, () =>
4646
runInFrame(b, () => cb(new ConfigurationView(this.workbench))),

0 commit comments

Comments
 (0)