Add node 14 support and update Github Action (#133)

* gh action node 14 support

* fix tests for engines lower than 12

* add beta tag to setup node v2

* change engine version

* remove node 8 from ci workflow matrix

Author: notanengineercom

.github/workflows/nodejs.yml

@@ -9,17 +9,17 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [8.x, 10.x, 12.x]
+        node-version: ['10.x', '12.x', '14.x']
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
+      uses: actions/setup-node@v2-beta
       with:
         node-version: ${{ matrix.node-version }}
-    - name: npm install, build, and test
+    - name: install dependencies, build and test
       run: |
-        npm install
+        npm ci
         npm run build --if-present
         npm test
       env:

package.json

@@ -26,7 +26,7 @@
         "url": "https://github.com/ffMathy/FluffySpoon.JavaScript.Testing.Faking/issues"
     },
     "engines": {
-        "node": ">=8"
+        "node": ">=10"
     },
     "main": "dist/src/index.js",
     "typings": "./dist/src/index.d.ts",

spec/returns.spec.ts

@@ -1,7 +1,9 @@
 import test from 'ava';
-import { Substitute, Arg } from '../src';
 import { inspect } from 'util'
 
+import { Substitute, Arg } from '../src';
+import { getCorrectConstructorDescriptor } from './util/compatibility';
+
 interface Calculator {
   add(a: number, b: number): number;
   multiply(a: number, b?: number): number;
@@ -28,7 +30,7 @@ test('returns a primitive value for method with specific arguments', t => {
 
   t.is(calculator.add(1, 1), 2);
   t.is(calculator.add(1, 1), 2);
-  t.is(inspect(noResult.constructor), '[Function: SubstituteJS]');
+  t.is(inspect(noResult.constructor), `[${getCorrectConstructorDescriptor()} SubstituteJS]`);
 });
 
 test('returns a primitive value for method with specific arguments where the last argument is optional', t => {
@@ -46,8 +48,8 @@ test('returns a primitive value for method with specific arguments where the las
   const noResult = calculator.multiply(2, 2);
   const noResult2 = calculator.multiply(0);
 
-  t.is(inspect(noResult.constructor), '[Function: SubstituteJS]');
-  t.is(inspect(noResult2.constructor), '[Function: SubstituteJS]');
+  t.is(inspect(noResult.constructor), `[${getCorrectConstructorDescriptor()} SubstituteJS]`);
+  t.is(inspect(noResult2.constructor), `[${getCorrectConstructorDescriptor()} SubstituteJS]`);
 });
 
 test('returns a primitive value for method with specific and conditional arguments', t => {
@@ -97,7 +99,7 @@ test('returns a promise for method with specific arguments', async t => {
   const noResult = calculator.heavyOperation(1, 1, 1);
 
   t.is(result, true);
-  t.is(inspect(noResult.constructor), '[Function: SubstituteJS]');
+  t.is(inspect(noResult.constructor), `[${getCorrectConstructorDescriptor()} SubstituteJS]`);
 });
 
 test('returns a promise for method with specific and conditional arguments', async t => {
@@ -151,7 +153,7 @@ test('returns a primitive value on a property', t => {
 
   t.is(calculator.isEnabled, true);
   t.is(calculator.isEnabled, true);
-  t.is(inspect(noResult.constructor), '[Function: SubstituteJS]');
+  t.is(inspect(noResult.constructor), `[${getCorrectConstructorDescriptor()} SubstituteJS]`);
 });
 
 test('returns a promise on a property', async t => {

spec/util/compatibility.ts

@@ -0,0 +1,6 @@
+export const getCorrectConstructorDescriptor = () => {
+  const nodeVersionLowerThan12 = Number(process.versions.node.split('.')[0]) < 12;
+  return nodeVersionLowerThan12 ?
+    'Function:' :
+    'class';
+};

src/SubstituteBase.ts

@@ -10,30 +10,30 @@ export class SubstituteJS {
     return typeof this._lastRegisteredSubstituteJSMethodOrProperty === 'undefined' ? 'root' : this._lastRegisteredSubstituteJSMethodOrProperty;
   }
   [Symbol.toPrimitive]() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   [Symbol.toStringTag]() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   [Symbol.iterator]() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   [inspect.custom]() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   valueOf() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   $$typeof() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   toString() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
   inspect() {
-    return `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+    return `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
   }
-  length = `[Function: ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
+  length = `[class ${this.constructor.name}] -> ${this.lastRegisteredSubstituteJSMethodOrProperty}`;
 }
 
 enum SubstituteExceptionTypes {