fix types for typescript < 4.6

notanengineercom · notanengineercom · commit 320477d57f37 · 2022-10-08T19:00:23.000+02:00
diff --git a/src/Recorder.ts b/src/Recorder.ts
@@ -62,6 +62,7 @@ export class Recorder<TRecord> {
   }
 
   private getIdentity(record: TRecord): PropertyKey {
-    return record[this._identity as keyof TRecord] as PropertyKey
+    // for typescript < 4.6, we need to intersect PropertyKey with the default type
+    return record[this._identity as keyof TRecord] as TRecord[keyof TRecord] & PropertyKey
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ export class Recorder<TRecord> {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`private getIdentity(record: TRecord): PropertyKey {`
`65`		`- return record[this._identity as keyof TRecord] as PropertyKey`
	`65`	`+ // for typescript < 4.6, we need to intersect PropertyKey with the default type`
	`66`	`+ return record[this._identity as keyof TRecord] as TRecord[keyof TRecord] & PropertyKey`
`66`	`67`	`}`
`67`	`68`	`}`