Skip to content

Commit 2c6fcab

Browse files
committed
refactor: fix unknown error with partial wrapping & send a falsy value when error
1 parent cf54865 commit 2c6fcab

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/Router.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ const CourseEnrollmentsPage = lazy(() => import('@src/enrollments/CourseEnrollme
1111

1212
const Router = () => (
1313
<Suspense fallback={<div>Loading...</div>}>
14-
<WouterRouter base={paths.base}>
15-
<Switch>
16-
<Route path={paths.partners.path} component={CorporatePartnerPage} />
17-
<CatalogEditionModalProvider>
14+
<CatalogEditionModalProvider>
15+
<WouterRouter base={paths.base}>
16+
<Switch>
17+
<Route path={paths.partners.path} component={CorporatePartnerPage} />
1818
<Route path={paths.catalogs.path} component={PartnerCatalogsPage} />
1919
<Route path={paths.courses.path} component={CoursesPage} />
20-
</CatalogEditionModalProvider>
21-
<Route path={paths.courseDetail.path} component={CourseEnrollmentsPage} />
22-
<Route>
23-
<h1>404 Not Found</h1>
24-
</Route>
25-
</Switch>
26-
</WouterRouter>
20+
<Route path={paths.courseDetail.path} component={CourseEnrollmentsPage} />
21+
<Route>
22+
<h1>404 Not Found</h1>
23+
</Route>
24+
</Switch>
25+
</WouterRouter>
26+
</CatalogEditionModalProvider>
2727
</Suspense>
2828
);
2929

src/courses/api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ export const deleteCourse = async (partnerId: string, catalogId: string, courseI
2929
};
3030

3131
export const getCourseDetails = async (partnerId: string, catalogId: string, courseId: number)
32-
: Promise<CorporateCourse> => {
32+
: Promise<CorporateCourse | null> => {
3333
try {
3434
const { data } = await getAuthenticatedHttpClient().get(`${getConfig().LMS_BASE_URL}/corporate_access/api/v1/partners/${partnerId}/catalogs/${catalogId}/courses/${courseId}/`);
3535
return camelCaseObject(data);
3636
} catch (error) {
3737
logError(error);
38-
return {} as CorporateCourse;
38+
return null;
3939
}
4040
};

0 commit comments

Comments
 (0)