Skip to content

Commit 994a898

Browse files
committed
improve documentation
1 parent 047a282 commit 994a898

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

.github/workflows/binder-nbval.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: NBVAL on binder container
22

3+
# We use `repo2docker` to build the docker image. Same as would happen on myBinder (or other Binder instances)
4+
35
on:
46
pull_request:
57
branches: [ master ]

binder/info.org

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,3 @@ leaner definition of dependencies.
1212
Binder should look in this directory (as it is called 'binder') and ignore the
1313
global Dockerfile.
1414

15-
* Re-use dependencies from development environment in myBinder
16-
17-
I don't know if myBinder could read dependencies from a pyproject.toml file (and
18-
couldn't find any documentation on this yet), nor if we can extract a
19-
requirements.txt file from the pyproject.toml file automatically.
20-
21-
As a first step towards making the binder image leaner, I will stick to a definition via a Dockerfile, and leave out latex to make it smaller.
22-
23-
This didn't go so well.
24-
25-
Next attempt: specifying the packages we need in requirements.txt directly. It's
26-
not ideal, as we don't run tests on the particular versions, and we duplicate
27-
some effort from ../pyproject.toml here in reqiuirements.txt. On the positive
28-
side, Binder start-up time could be much smaller (and Binder work at all).
29-
30-

0 commit comments

Comments
 (0)