-
Notifications
You must be signed in to change notification settings - Fork 280
Open
Description
Entries which end close to window border PathPicker cause infinite loop after trying to select them with either f or F.
Following for loop is affected:
PathPicker/src/pathpicker/screen_control.py
Lines 668 to 673 in cc032b2
| for index in self.dirty_indexes: | |
| y_pos = min_y + index + self.get_scroll_offset() | |
| if min_y <= y_pos < max_y: | |
| did_clear_line = True | |
| self.clear_line(y_pos) | |
| self.line_objs[index].output(self.color_printer) |
Seemingly due to reaching this code path:
PathPicker/src/pathpicker/line_format.py
Lines 300 to 306 in cc032b2
| if important_text_length > space_for_printing: | |
| # hrm, we need to update our decorated match to show | |
| # a truncated version since right now we will print off | |
| # the screen. lets also dump the beforeText for more | |
| # space | |
| self.update_decorated_match(max_len=space_for_printing) | |
| self.is_truncated = True |
Which apparently keeps adding dirty indexes forever:
PathPicker/src/pathpicker/line_format.py
Lines 237 to 238 in cc032b2
| if self.controller: | |
| self.controller.dirty_line(self.index) |
Metadata
Metadata
Assignees
Labels
No labels