do not break forms which are not using a changeset

Author: jelhan

addon/components/bs-form/element.js

@@ -7,12 +7,12 @@ export default class BsFormElementWithChangesetValidationsSupport extends BsForm
 
   @dependentKeyCompat
   get errors() {
-    let error = this.model.error[this.property]?.validation;
+    let error = this.model?.error?.[this.property]?.validation;
     return error ? [error] : [];
   }
 
   get hasValidator() {
-    return typeof this.model.validate === 'function';
+    return typeof this.model?.validate === 'function';
   }
 
   // Ember Changeset does not validate the initial state. Properties are not

tests/integration/components/bs-form-element-test.js

@@ -133,4 +133,54 @@ module('Integration | Component | bs form element', function(hooks) {
     await blur('input');
     assert.dom('input').hasClass('is-valid', 'validation error is shown after focus out');
   });
+
+  test('does not break forms which are not using a changeset as model', async function(assert) {
+    this.set('model', { name: '' });
+    this.set('submitAction', () => {
+      assert.step('submit action has been called');
+    });
+
+    await render(hbs`
+      <BsForm @model={{this.model}} @onSubmit={{this.submitAction}} as |form|>
+        <form.element @label="Name" @property="name" />
+      </BsForm>
+    `);
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+
+    await fillIn('input', 'Rosa');
+    await blur('input');
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+
+    await triggerEvent('form', 'submit');
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+    assert.verifySteps(['submit action has been called']);
+  });
+
+  test('does not break for forms which are not having a model at all', async function(assert) {
+    this.set('submitAction', () => {
+      assert.step('submit action has been called');
+    });
+    this.set('noop', () => {});
+
+    await render(hbs`
+      <BsForm @onSubmit={{this.submitAction}} as |form|>
+        <form.element @label="Name" @property="name" @onChange={{this.noop}} />
+      </BsForm>
+    `);
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+
+    await fillIn('input', 'Rosa');
+    await blur('input');
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+
+    await triggerEvent('form', 'submit');
+    assert.dom('input').doesNotHaveClass('is-valid');
+    assert.dom('input').doesNotHaveClass('is-invalid');
+    assert.verifySteps(['submit action has been called']);
+  });
 });