Skip to content

Small flaw in the code #1

@embeddedmz

Description

@embeddedmz

To make the vertical axis labels (time) fall with the waterfall layers, I had to make a hack that could possibly cause problems after a very large number of waterfall refreshes.

IIRC, the hack is located in the ‘Waterfallplot::addData’ method :

const double yMin = (m_zoomActive) ? yDiv.lowerBound() + 1 : currentOffset;
const double yMax = (m_zoomActive) ? yDiv.upperBound() + 1 : maxHistory + currentOffset;

After a certain amount of time (quite a lot, perhaps tens or hundreds of years), the double variable will overflow by losing precision and the waterfall will no longer be displayed correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem right

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions