Notification sends whenever a new window is opened

[danirabbit]

What Happened?

We've gone wrong somewhere here and now notifications are sent whenever a new window opens. The first window's notification bubble is invisible (maybe withdrawn immediately?), but subsequent windows send the full notification for the last executed command

Steps to Reproduce

1. Open terminal
2. Hear the notification chime, but no bubble
3. Open a new terminal window
4. this time also get a bubble

Expected Behavior

Notifications shouldn't be send for brand new windows that haven't had commands entered into them yet

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland, This is the default)

Software Version

Compiled from git

Log Output

Hardware Info

No response

[jeremypw]

Hmm, yes and even more annoying if you run e.g. Code from Terminal then every command executed in Code's terminal pane produces a (non-persistent) notification. Will investigate.

[lenemter]

I guess this regression was introduced in #978

[jeremypw]

So it did do something after all ... Needs to be reinstated with a comment I guess (or replaced with something better).

I notice that I am also getting notifications on startup about the last processes that completed during the previous Terminal session!

[jeremypw]

The linked reversion fixes the spurious notifications during startup. However, the unwanted notifications from processes completed within processes running within Terminal is still present. That might have been present but unreported before the port. It needs a separate issue raised.

[lenemter]

@jeremypw Yes, I have this issue with Visual Studio Code and it has been going on for about a year or two