Bug 521515: Build pty.dll in docker (fixup)

Fixes for items identified by Torbjörn in my changes to commit
2d03236

Change-Id: I51f289f731062b4a43bb041d25cd08467014151e

Author: jonahgraham

core/org.eclipse.cdt.core.native/native_src/Makefile

@@ -89,7 +89,7 @@ $(OS_DIR_WIN32_X86_64)/pty.dll: win/pty.cpp win/pty_dllmain.cpp
 	x86_64-w64-mingw32-g++ -o $@ -Iinclude -Iwin/include -I"$(JAVA_HOME)/include" -I"$(JAVA_HOME)/include/win32" \
 		-DUNICODE \
 		win/pty.cpp win/pty_dllmain.cpp \
-		-Wl,--kill-at --shared -L$(OS_DIR_WIN32_X86_64) -lwinpty # -static-libstdc++ -static-libgcc
+		-Wl,--kill-at --shared -L$(OS_DIR_WIN32_X86_64) -lwinpty -static-libstdc++ -static-libgcc
 
 # Linux x86_64
 $(OS_DIR_LINUX_X86_64)/libspawner.so: unix/spawner.c unix/io.c unix/exec_unix.c unix/exec_pty.c unix/openpty.c unix/pfind.c

core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/pty/PTY.java

@@ -262,15 +262,15 @@ native int exec2(String[] cmdarray, String[] envp, String dir, IChannel[] chan,
 
 	static {
 		try {
-			if (Platform.OS_WIN32.equals(Platform.getOS())) {
+			isWinPTY = Platform.OS_WIN32.equals(Platform.getOS());
+			if (isWinPTY) {
 				// When we used to build with VC++ we used DelayLoadDLLs (See Gerrit 167674 and Bug 521515) so that the winpty
 				// could be found. When we ported to mingw we didn't port across this feature because it was simpler to just
 				// manually load winpty first.
 				System.loadLibrary("winpty"); //$NON-NLS-1$
 			}
 			System.loadLibrary("pty"); //$NON-NLS-1$
 			hasPTY = true;
-			isWinPTY = Platform.OS_WIN32.equals(Platform.getOS());
 			// on windows console mode is not supported except for experimental use
 			// to enable it, set system property org.eclipse.cdt.core.winpty_console_mode=true
 			isConsoleModeSupported = !isWinPTY || Boolean.getBoolean("org.eclipse.cdt.core.winpty_console_mode"); //$NON-NLS-1$