Skip to content

Commit 2f5548d

Browse files
laeubijonahgraham
authored andcommitted
Remove WinPTY support
WinPTY is no longer well supported and maybe even non functional anymore.
1 parent 8b22be8 commit 2f5548d

File tree

10 files changed

+20
-606
lines changed

10 files changed

+20
-606
lines changed

NewAndNoteworthy/CDT-12.3.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@ This is the New & Noteworthy page for CDT 12.3 which is part of Eclipse 2025-12
1010

1111
Core Build CMake and Makefile projects now support the Gdb Remote TCP and Serial launch targets.
1212

13+
## Support for WinPTY terminals has been removed
14+
15+
Since CDT 10.6 the default settings in CDT has [been to not use WinPTY](https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-10.6.md#windows-pseudo-console-conpty-the-default).
16+
With this release of CDT the WinPTY version of the code has been removed.
17+
The WinPTY code was known to not work in many circumstances.
18+
The replacement Windows Pseudo Console (ConPTY) API is much more stable.
1319

1420
# API Changes, current and planned
1521

core/org.eclipse.cdt.core.native/native_src/Makefile

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ ifeq ($(UNAME),Linux)
3838
LIBS = \
3939
$(OS_DIR_WIN32_X86_64)/starter.exe \
4040
$(OS_DIR_WIN32_X86_64)/spawner.dll \
41-
$(OS_DIR_WIN32_X86_64)/pty.dll \
4241
$(OS_DIR_LINUX_X86_64)/libspawner.so \
4342
$(OS_DIR_LINUX_X86_64)/libpty.so \
4443
$(OS_DIR_LINUX_AARCH64)/libspawner.so \
@@ -68,8 +67,7 @@ LIBS = \
6867
else
6968
LIBS = \
7069
$(OS_DIR_WIN32_X86_64)/starter.exe \
71-
$(OS_DIR_WIN32_X86_64)/spawner.dll \
72-
$(OS_DIR_WIN32_X86_64)/pty.dll
70+
$(OS_DIR_WIN32_X86_64)/spawner.dll
7371
endif
7472
endif
7573
endif
@@ -87,7 +85,6 @@ MAC_TO_SIGN=$(OS_DIR_MACOS_X86_64)/libspawner.jnilib \
8785
$(OS_DIR_MACOS_AARCH64)/libpty.jnilib
8886
WIN_TO_SIGN=$(OS_DIR_WIN32_X86_64)/starter.exe \
8987
$(OS_DIR_WIN32_X86_64)/spawner.dll \
90-
$(OS_DIR_WIN32_X86_64)/pty.dll \
9188
$(OS_DIR_WIN32_AARCH64)/starter.exe \
9289
$(OS_DIR_WIN32_AARCH64)/spawner.dll
9390
### This block of code also exists in native/org.eclipse.cdt.native.serial/native_src/Makefile
@@ -130,14 +127,6 @@ $(OS_DIR_WIN32_X86_64)/spawner.dll: win/iostream.c win/raise.c win/spawner.c win
130127
$^ \
131128
-Wl,--kill-at --shared
132129

133-
$(OS_DIR_WIN32_X86_64)/pty.dll: win/pty.cpp win/pty_dllmain.cpp win/util.c
134-
mkdir -p $(dir $@) && \
135-
$(REPRODUCIBLE_BUILD_WRAPPER) \
136-
x86_64-w64-mingw32-g++ $(COMMON_CCFLAGS) -o $@ -Iinclude -Iwin/include -I"$(JAVA_HOME)/include" -I"$(JAVA_HOME)/include/win32" \
137-
-DUNICODE \
138-
$^ \
139-
-Wl,--kill-at --shared -L$(OS_DIR_WIN32_X86_64) -lwinpty -static-libstdc++ -static-libgcc
140-
141130
# Windows aarch64
142131
$(OS_DIR_WIN32_AARCH64)/starter.exe: win/starter.c win/util.c
143132
mkdir -p $(dir $@) && \

core/org.eclipse.cdt.core.native/native_src/include/org_eclipse_cdt_utils_pty_PTY.h

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/org.eclipse.cdt.core.native/native_src/win/include/winpty.h

Lines changed: 0 additions & 105 deletions
This file was deleted.

0 commit comments

Comments
 (0)