-
Notifications
You must be signed in to change notification settings - Fork 241
use az rest --method GET instead of az ad app list #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
68a53d2 to
c4336ff
Compare
|
/backport to release/10.0 |
|
Started backporting to |
src/dotnet-scaffolding/dotnet-scaffold/AspNet/Helpers/AzCliHelper.cs
Outdated
Show resolved
Hide resolved
c4336ff to
9ebf04b
Compare
| } | ||
|
|
||
| // Format as "DisplayName (AppId)" for better user experience | ||
| appIds.Add($"{displayName} ({id})"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the split logic here:
Line 90 in 11bf37d
| string id = entraSettings.SelectApplication.Split(" ").Last(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I dont think it makes sense to have the parenthesis here. keeping them out
9ebf04b to
bc5b7f4
Compare
|
/backport to release/10.0 |
|
Started backporting to |
az ad app listis slow. It can spin for at least 10 minutes for large subscriptions. Instead of making the user wait foraz ad app listto finish when running theEntra Idscaffolder, instead invokeaz rest --method GET. Also in the process of testing, I found that if the app names contain[and], the UI will throw because Spectre.Console expects known colors in that format