Skip to content
This repository was archived by the owner on Dec 16, 2019. It is now read-only.

Commit 4bae1a7

Browse files
committed
Fixed bug where onItemSelect was fired for each item on selectAll closes #34
1 parent b805886 commit 4bae1a7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/angularjs-dropdown-multiselect.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,9 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co
335335
if ($scope.singleSelection) {
336336
clearObject($scope.selectedModel);
337337
angular.extend($scope.selectedModel, finalObj);
338-
$scope.externalEvents.onItemSelect(finalObj);
338+
if (fireSelectionChange) {
339+
$scope.externalEvents.onItemSelect(finalObj);
340+
}
339341
if ($scope.settings.closeOnSelect || $scope.settings.closeOnDeselect) $scope.close();
340342
} else {
341343
dontRemove = dontRemove || false;
@@ -348,7 +350,9 @@ directiveModule.directive('ngDropdownMultiselect', ['$filter', '$document', '$co
348350
if ($scope.settings.closeOnDeselect) $scope.close();
349351
} else if (!exists && ($scope.settings.selectionLimit === 0 || $scope.selectedModel.length < $scope.settings.selectionLimit)) {
350352
$scope.selectedModel.push(finalObj);
351-
$scope.externalEvents.onItemSelect(finalObj);
353+
if (fireSelectionChange) {
354+
$scope.externalEvents.onItemSelect(finalObj);
355+
}
352356
if ($scope.settings.closeOnSelect) $scope.close();
353357
if ($scope.settings.selectionLimit > 0 && $scope.selectedModel.length === $scope.settings.selectionLimit) {
354358
$scope.externalEvents.onMaxSelectionReached();

0 commit comments

Comments
 (0)