Skip to content

Commit ee431f2

Browse files
committed
Update internal read_bin_goto_object function to return void
This function is not exposed in the header file and it always returns `false` therefore we can apply this simplification.
1 parent e0d3a08 commit ee431f2

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/goto-programs/read_bin_goto_object.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ static void read_bin_functions_object(
191191

192192
/// read goto binary format
193193
/// \par parameters: input stream, symbol_table, functions
194-
/// \return true on error, false otherwise
195-
static bool read_bin_goto_object(
194+
static void read_bin_goto_object(
196195
std::istream &in,
197196
symbol_table_baset &symbol_table,
198197
goto_functionst &functions,
@@ -201,7 +200,6 @@ static bool read_bin_goto_object(
201200
read_bin_symbol_table_object(in, symbol_table, irepconverter);
202201
copy_parameter_identifiers(symbol_table, functions);
203202
read_bin_functions_object(in, functions, irepconverter);
204-
return false;
205203
}
206204

207205
/// reads a goto binary file back into a symbol and a function table
@@ -269,7 +267,8 @@ bool read_bin_goto_object(
269267
}
270268
else if(version == GOTO_BINARY_VERSION)
271269
{
272-
return read_bin_goto_object(in, symbol_table, functions, irepconverter);
270+
read_bin_goto_object(in, symbol_table, functions, irepconverter);
271+
return false;
273272
}
274273
else
275274
{

0 commit comments

Comments
 (0)