Merge pull request #5664 from tautschnig/empty-union-initialiser

Do not fail an internal invariant when initialising an empty union

Author: kroening

regression/ansi-c/Union_Initialization2/main.c

@@ -0,0 +1,5 @@
+union a {
+} b()
+{
+  union a c = {0};
+}

regression/ansi-c/Union_Initialization2/test.desc

@@ -0,0 +1,11 @@
+CORE
+main.c
+
+union member designator found for empty union
+^SIGNAL=0$
+^EXIT=(1|64)$
+--
+member designator is bounded by components size
+--
+This test previously failed an internal invariant, which is not the correct
+behaviour the problem can be triggered by user input.

src/ansi-c/c_typecheck_initializer.cpp

@@ -478,10 +478,21 @@ exprt::operandst::const_iterator c_typecheck_baset::do_designated_initializer(
       const union_typet::componentst &components=
         union_type.components();
 
-      DATA_INVARIANT(index<components.size(),
-                     "member designator is bounded by components size");
+      if(components.empty())
+      {
+        error().source_location = value.source_location();
+        error() << "union member designator found for empty union" << eom;
+        throw 0;
+      }
+      else if(index >= components.size())
+      {
+        error().source_location = value.source_location();
+        error() << "union member designator " << index << " out of bounds ("
+                << components.size() << ")" << eom;
+        throw 0;
+      }
 
-      const union_typet::componentt &component=union_type.components()[index];
+      const union_typet::componentt &component = components[index];
 
       if(dest->id()==ID_union &&
          dest->get(ID_component_name)==component.get_name())