remove namespacet from does_remove_constt

Author: kroening

src/analyses/does_remove_const.cpp

@@ -18,13 +18,8 @@ Author: Diffblue Ltd.
 
 /// A naive analysis to look for casts that remove const-ness from pointers.
 /// \param goto_program: the goto program to check
-/// \param ns: the namespace of the goto program (used for checking type
-///   equality)
-does_remove_constt::does_remove_constt(
-  const goto_programt &goto_program,
-  const namespacet &ns):
-    goto_program(goto_program),
-    ns(ns)
+does_remove_constt::does_remove_constt(const goto_programt &goto_program)
+  : goto_program(goto_program)
 {}
 
 /// A naive analysis to look for casts that remove const-ness from pointers.

src/analyses/does_remove_const.h

@@ -14,15 +14,14 @@ Author: Diffblue Ltd.
 #include <utility>
 
 class goto_programt;
-class namespacet;
 class exprt;
 class source_locationt;
 class typet;
 
 class does_remove_constt
 {
 public:
-  does_remove_constt(const goto_programt &goto_program, const namespacet &ns);
+  explicit does_remove_constt(const goto_programt &);
   std::pair<bool, source_locationt>  operator()() const;
 
 private:
@@ -35,7 +34,6 @@ class does_remove_constt
     const typet *target_type, const typet *source_type) const;
 
   const goto_programt &goto_program;
-  const namespacet &ns;
 
   friend class does_remove_const_testt;
 };

src/goto-programs/remove_function_pointers.cpp

@@ -270,7 +270,7 @@ void remove_function_pointerst::remove_function_pointer(
 
   const exprt &pointer = function.pointer();
   remove_const_function_pointerst::functionst functions;
-  does_remove_constt const_removal_check(goto_program, ns);
+  does_remove_constt const_removal_check(goto_program);
   const auto does_remove_const = const_removal_check();
   messaget log{message_handler};
   if(does_remove_const.first)

unit/analyses/does_remove_const/does_expr_lose_const.cpp

@@ -30,7 +30,7 @@ SCENARIO("does_expr_lose_const",
   symbol_tablet symbol_table;
   namespacet ns(symbol_table);
   goto_programt program;
-  does_remove_constt does_remove_const(program, ns);
+  does_remove_constt does_remove_const(program);
   does_remove_const_testt does_remove_const_test(does_remove_const);
 
   GIVEN("Const and non-const primitive and pointers to primitives")

unit/analyses/does_remove_const/does_type_preserve_const_correctness.cpp

@@ -29,7 +29,7 @@ SCENARIO("does_type_preserve_const_correctness",
   symbol_tablet symbol_table;
   namespacet ns(symbol_table);
   goto_programt program;
-  does_remove_constt does_remove_const(program, ns);
+  does_remove_constt does_remove_const(program);
   does_remove_const_testt does_remove_const_test(does_remove_const);
 
   GIVEN("Const and non-const primitive and pointers to primitives")

unit/analyses/does_remove_const/is_type_at_least_as_const_as.cpp

@@ -29,7 +29,7 @@ SCENARIO("is_type_at_least_as_const",
   symbol_tablet symbol_table;
   namespacet ns(symbol_table);
   goto_programt program;
-  does_remove_constt does_remove_const(program, ns);
+  does_remove_constt does_remove_const(program);
   does_remove_const_testt does_remove_const_test(does_remove_const);
 
   GIVEN("Const and non-const primitive and pointers to primitives")