Remove useless const on POD return-type

Reported by Semmle's LGTM
(https://lgtm.com/projects/g/diffblue/cbmc/alerts/?mode=list).

Author: tautschnig

jbmc/src/java_bytecode/generic_parameter_specialization_map_keys.cpp

@@ -39,7 +39,7 @@ get_all_generic_parameters(const typet &type)
 /// on destruction; otherwise do nothing.
 /// \param parameters generic parameters that are the keys of the pairs to add
 /// \param types a type to add for each parameter
-const void generic_parameter_specialization_map_keyst::insert_pairs(
+void generic_parameter_specialization_map_keyst::insert_pairs(
   const std::vector<java_generic_parametert> &parameters,
   const std::vector<reference_typet> &types)
 {
@@ -90,7 +90,7 @@ const void generic_parameter_specialization_map_keyst::insert_pairs(
 /// \param pointer_type pointer type to get the specialized generic types from
 /// \param pointer_subtype_struct struct type to which the generic pointer
 /// points, must be generic if the pointer is generic
-const void generic_parameter_specialization_map_keyst::insert_pairs_for_pointer(
+void generic_parameter_specialization_map_keyst::insert_pairs_for_pointer(
   const pointer_typet &pointer_type,
   const typet &pointer_subtype_struct)
 {
@@ -139,7 +139,7 @@ const void generic_parameter_specialization_map_keyst::insert_pairs_for_pointer(
 /// \param symbol_type symbol type to get the specialized generic types from
 /// \param symbol_struct struct type of the symbol type, must be generic if
 /// the symbol is generic
-const void generic_parameter_specialization_map_keyst::insert_pairs_for_symbol(
+void generic_parameter_specialization_map_keyst::insert_pairs_for_symbol(
   const symbol_typet &symbol_type,
   const typet &symbol_struct)
 {

jbmc/src/java_bytecode/generic_parameter_specialization_map_keys.h

@@ -47,10 +47,10 @@ class generic_parameter_specialization_map_keyst
   generic_parameter_specialization_map_keyst &
   operator=(const generic_parameter_specialization_map_keyst &) = delete;
 
-  const void insert_pairs_for_pointer(
+  void insert_pairs_for_pointer(
     const pointer_typet &pointer_type,
     const typet &pointer_subtype_struct);
-  const void insert_pairs_for_symbol(
+  void insert_pairs_for_symbol(
     const symbol_typet &symbol_type,
     const typet &symbol_struct);
 
@@ -60,7 +60,7 @@ class generic_parameter_specialization_map_keyst
   /// Keys of the entries to pop on destruction
   std::vector<irep_idt> erase_keys;
 
-  const void insert_pairs(
+  void insert_pairs(
     const std::vector<java_generic_parametert> &parameters,
     const std::vector<reference_typet> &types);
 };

jbmc/src/java_bytecode/java_types.h

@@ -111,7 +111,7 @@ class java_class_typet:public class_typet
     return set(ID_access, access);
   }
 
-  const bool get_is_inner_class() const
+  bool get_is_inner_class() const
   {
     return get_bool(ID_is_inner_class);
   }
@@ -141,7 +141,7 @@ class java_class_typet:public class_typet
     return set(ID_super_class, super_class);
   }
 
-  const bool get_is_static_class() const
+  bool get_is_static_class() const
   {
     return get_bool(ID_is_static);
   }
@@ -151,7 +151,7 @@ class java_class_typet:public class_typet
     return set(ID_is_static, is_static_class);
   }
 
-  const bool get_is_anonymous_class() const
+  bool get_is_anonymous_class() const
   {
     return get_bool(ID_is_anonymous);
   }

src/goto-cc/linker_script_merge.h

@@ -50,7 +50,7 @@ class replacement_predicatet
   /// If this function returns true, the entire expression should be replaced by
   /// a pointer whose underlying symbol is the symbol returned by
   /// replacement_predicatet::inner_symbol().
-  const bool match(const exprt &expr, const namespacet &ns) const
+  bool match(const exprt &expr, const namespacet &ns) const
   {
     return _match(expr, ns);
   };