Simplification of irep_serializationt::read_string_ref

tautschnig · tautschnig · commit 2150648ef04c · 2018-10-08T09:58:59.000Z
Avoids duplicating the same statement.
diff --git a/src/util/irep_serialization.cpp b/src/util/irep_serialization.cpp
@@ -247,15 +247,12 @@ irep_idt irep_serializationt::read_string_ref(std::istream &in)
     ireps_container.string_rev_map.resize(1+id*2,
       std::pair<bool, irep_idt>(false, irep_idt()));
 
-  if(ireps_container.string_rev_map[id].first)
-  {
-    return ireps_container.string_rev_map[id].second;
-  }
-  else
+  if(!ireps_container.string_rev_map[id].first)
   {
     irep_idt s=read_gb_string(in);
     ireps_container.string_rev_map[id]=
       std::pair<bool, irep_idt>(true, s);
-    return ireps_container.string_rev_map[id].second;
   }
+
+  return ireps_container.string_rev_map[id].second;
 }

Original file line number	Diff line number	Diff line change
`@@ -247,15 +247,12 @@ irep_idt irep_serializationt::read_string_ref(std::istream &in)`
`247`	`247`	`ireps_container.string_rev_map.resize(1+id*2,`
`248`	`248`	`std::pair<bool, irep_idt>(false, irep_idt()));`
`249`	`249`
`250`		`- if(ireps_container.string_rev_map[id].first)`
`251`		`- {`
`252`		`- return ireps_container.string_rev_map[id].second;`
`253`		`- }`
`254`		`- else`
	`250`	`+ if(!ireps_container.string_rev_map[id].first)`
`255`	`251`	`{`
`256`	`252`	`irep_idt s=read_gb_string(in);`
`257`	`253`	`ireps_container.string_rev_map[id]=`
`258`	`254`	`std::pair<bool, irep_idt>(true, s);`
`259`		`- return ireps_container.string_rev_map[id].second;`
`260`	`255`	`}`
	`256`	`+`
	`257`	`+ return ireps_container.string_rev_map[id].second;`
`261`	`258`	`}`