Set the default implementation of make_entry to make_top

This is used by the majority of domains and if you don't want to / can't
implement make_top() then you probably want a custom make_entry() anyway.
This is a net saving of code!

Author: martin

src/analyses/ai_domain.h

@@ -113,12 +113,16 @@ class ai_domain_baset
   /// no states
   virtual void make_bottom() = 0;
 
-  /// all states -- the analysis doesn't use this,
+  /// all states -- the analysis doesn't use this directly (see make_entry)
   /// and domains may refuse to implement it.
   virtual void make_top() = 0;
 
   /// Make this domain a reasonable entry-point state
-  virtual void make_entry() = 0;
+  /// For most domains top is sufficient
+  virtual void make_entry()
+  {
+    make_top();
+  }
 
   virtual bool is_bottom() const = 0;
 

src/analyses/constant_propagator.h

@@ -65,11 +65,6 @@ class constant_propagator_domaint:public ai_domain_baset
     values.set_to_top();
   }
 
-  virtual void make_entry() final override
-  {
-    make_top();
-  }
-
   virtual bool is_bottom() const final override
   {
     return values.is_bot();

src/analyses/custom_bitvector_analysis.h

@@ -50,11 +50,6 @@ class custom_bitvector_domaint:public ai_domain_baset
     has_values=tvt(true);
   }
 
-  void make_entry() final override
-  {
-    make_top();
-  }
-
   bool is_bottom() const final override
   {
     DATA_INVARIANT(!has_values.is_false() ||

src/analyses/escape_analysis.h

@@ -71,11 +71,6 @@ class escape_domaint:public ai_domain_baset
     return has_values.is_true();
   }
 
-  void make_entry() override final
-  {
-    make_top();
-  }
-
   typedef union_find<irep_idt> aliasest;
   aliasest aliases;
 

src/analyses/global_may_alias.h

@@ -62,11 +62,6 @@ class global_may_alias_domaint:public ai_domain_baset
     has_values=tvt(true);
   }
 
-  void make_entry() final override
-  {
-    make_top();
-  }
-
   /// Returns true if domain is bottom.
   bool is_bottom() const final override
   {

src/analyses/interval_domain.h

@@ -69,11 +69,6 @@ class interval_domaint:public ai_domain_baset
     bottom=false;
   }
 
-  void make_entry() final override
-  {
-    make_top();
-  }
-
   bool is_bottom() const override final
   {
     #if 0

src/analyses/reaching_definitions.h

@@ -209,11 +209,6 @@ class rd_range_domaint:public ai_domain_baset
     has_values=tvt(false);
   }
 
-  void make_entry() final override
-  {
-    make_top();
-  }
-
   bool is_top() const override final
   {
     DATA_INVARIANT(!has_values.is_true() || values.empty(),

src/analyses/uninitialized_domain.h

@@ -54,11 +54,6 @@ class uninitialized_domaint:public ai_domain_baset
     has_values=tvt(false);
   }
 
-  void make_entry() final override
-  {
-    make_top();
-  }
-
   bool is_top() const override final
   {
     DATA_INVARIANT(!has_values.is_true() || uninitialized.empty(),

src/analyses/variable-sensitivity/variable_sensitivity_dependence_graph.h

@@ -116,11 +116,6 @@ class variable_sensitivity_dependence_domaint
     control_dep_call_candidates.clear();
   }
 
-  void make_entry() override
-  {
-    make_top();
-  }
-
   bool is_bottom() const override
   {
     return variable_sensitivity_domaint::is_bottom() && has_values.is_false();

src/analyses/variable-sensitivity/variable_sensitivity_domain.cpp

@@ -218,11 +218,6 @@ void variable_sensitivity_domaint::make_top()
   abstract_state.make_top();
 }
 
-void variable_sensitivity_domaint::make_entry()
-{
-  abstract_state.make_top();
-}
-
 bool variable_sensitivity_domaint::merge(
   const variable_sensitivity_domaint &b,
   trace_ptrt from,