Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

  • Update Source/Device.swift.gyb to change "iPad Mini" to "iPad mini" in strings and comments (lines 120-126)
  • Regenerate Source/Device.generated.swift using the gyb tool
  • Update Tests/Tests.swift to match new "iPad mini" string values (lines 358-362)
  • Update CHANGELOG.md to reflect "iPad mini" naming (4 occurrences)
  • Add changelog entry under Unreleased for iPad mini naming fix
  • Run code review
  • Run CodeQL security scan
Original prompt

This section details on the original issue you should resolve

<issue_title>iPad Mini vs. iPad mini</issue_title>
<issue_description>Thank you for creating this amazing library.

If anyone is excited by nitpicky details, for consistency with Apple's naming, the capitalization of "iPad Mini" should be "iPad mini".

See Device.swift.gyb, lines 120 through 126

Device("iPadMini", "Device is an [iPad Mini](https://support.apple.com/kb/SP661)", "https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP661/sp661_ipad_mini_color.jpg", ["iPad2,5", "iPad2,6", "iPad2,7"], 7.9, (3, 4), "iPad Mini", "iPad Mini", 163, False, True, False, False, False, False, False, False, False, False, 0, False, 1, False, "a5", False, False),

Please let me know if you'd like me to create a PR for this issue.</issue_description>

<agent_instructions>Rename all iPad Mini to iPad mini with lowercase m. Only inside strings and comments. Keep the enum still with capital M according to lowerCamelCasing.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix capitalization of iPad Mini to iPad mini Rename iPad Mini to iPad mini for Apple naming consistency Dec 3, 2025
Copilot AI requested a review from Zandor300 December 3, 2025 19:50
Copilot finished work on behalf of Zandor300 December 3, 2025 19:50
@Zandor300
Copy link
Member

@copilot Please add a new changelog entry under unreleased about fixing naming of iPad mini.

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

15 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L752 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:752
⚠️ Source/Device.generated.swift#L1333 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1333
⚠️ Source/Device.generated.swift#L1599 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1599
⚠️ Source/Device.generated.swift#L1779 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1779
⚠️ Source/Device.generated.swift#L1939 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1939
⚠️ Source/Device.generated.swift#L2645 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2645
⚠️ Source/Device.generated.swift#L2706 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2706
⚠️ Tests/Tests.swift#L463 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:463
⚠️ Tests/Tests.swift#L496 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:496
⚠️ Tests/Tests.swift#L531 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:531
⚠️ Tests/Tests.swift#L538 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines
function_body_length Tests.swift:538
⚠️ Tests/Tests.swift#L580 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:580
⚠️ Tests/Tests.swift#L668 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:668
⚠️ Tests/Tests.swift#L709 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:709

SwiftLint found issues

Warnings

File Line Reason
Tests.swift 538 Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines (function_body_length)
Tests.swift 463 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 496 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 531 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 580 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 668 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 709 Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift 752 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1333 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1599 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1779 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1939 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2645 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2706 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot Please add a new changelog entry under unreleased about fixing naming of iPad mini.

Added the changelog entry under the Unreleased section in commit 304adfa.

@Zandor300 Zandor300 marked this pull request as ready for review December 3, 2025 19:56
Copilot finished work on behalf of Zandor300 December 3, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPad Mini vs. iPad mini

2 participants