partial support multi-platform build

Author: tky2240

src/spec-node/containerFeatures.ts

@@ -265,7 +265,7 @@ async function getFeaturesBuildOptions(params: DockerResolverParameters, devCont
 	const syntax = imageBuildInfo.dockerfile?.preamble.directives.syntax;
 	const omitSyntaxDirective = common.omitSyntaxDirective; // Can be removed when https://github.com/moby/buildkit/issues/4556 is fixed
 	const dockerfilePrefixContent = `${omitSyntaxDirective ? '' :
-		useBuildKitBuildContexts && !(imageBuildInfo.dockerfile && supportsBuildContexts(imageBuildInfo.dockerfile)) ? '# syntax=docker/dockerfile:1.4' :
+		useBuildKitBuildContexts && !(imageBuildInfo.dockerfile && supportsBuildContexts(imageBuildInfo.dockerfile)) ? '# syntax=docker/dockerfile:1.11' :
 		syntax ? `# syntax=${syntax}` : ''}
 ARG _DEV_CONTAINERS_BASE_IMAGE=placeholder
 `;

src/spec-node/devContainers.ts

@@ -172,7 +172,7 @@ export async function createDockerParams(options: ProvisionOptions, disposables:
 	}, dockerPath, dockerComposePath);
 
 	const platformInfo = (() => {
-		if (common.buildxPlatform) {
+		if (common.buildxPlatform && common.buildxPlatform.split(',').length === 1) {
 			const slash1 = common.buildxPlatform.indexOf('/');
 			const slash2 = common.buildxPlatform.indexOf('/', slash1 + 1);
 			// `--platform linux/amd64/v3` `--platform linux/arm64/v8`
@@ -189,7 +189,7 @@ export async function createDockerParams(options: ProvisionOptions, disposables:
 				arch: <GoARCH> common.buildxPlatform.slice(slash1 + 1),
 			};
 		} else {
-			// `--platform` omitted
+			// `--platform` omitted or multiple platforms
 			return {
 				os: mapNodeOSToGOOS(cliHost.platform),
 				arch: mapNodeArchitectureToGOARCH(cliHost.arch),

src/spec-node/dockerfileUtils.ts

@@ -5,6 +5,7 @@
 
 import * as semver from 'semver';
 import { Mount } from '../spec-configuration/containerFeaturesConfiguration';
+import { PlatformInfo } from '../spec-common/commonUtils';
 
 
 const findFromLines = new RegExp(/^(?<line>\s*FROM.*)/, 'gmi');
@@ -100,15 +101,28 @@ export function findUserStatement(dockerfile: Dockerfile, buildArgs: Record<stri
 	return undefined;
 }
 
-export function findBaseImage(dockerfile: Dockerfile, buildArgs: Record<string, string>, target: string | undefined) {
+export function findBaseImage(dockerfile: Dockerfile, buildArgs: Record<string, string>, target: string | undefined, platformInfo: PlatformInfo) {
 	let stage: Stage | undefined = target ? dockerfile.stagesByLabel[target] : dockerfile.stages[dockerfile.stages.length - 1];
 	const seen = new Set<Stage>();
 	while (stage) {
 		if (seen.has(stage)) {
 			return undefined;
 		}
 		seen.add(stage);
-
+		if (stage.from.image.includes('$')) {
+			buildArgs = {
+				...buildArgs,
+				TARGETPLATFORM: platformInfo.variant ? `${platformInfo.arch}/${platformInfo.os}/${platformInfo.variant}` : `${platformInfo.arch}/${platformInfo.os}`,
+				TARGETOS: platformInfo.os,
+				TARGETARCH: platformInfo.arch,
+			};
+			if (platformInfo.variant) {
+				buildArgs = {
+					...buildArgs,
+					TARGETVARIANT: platformInfo.variant,
+				};
+			}
+		}
 		const image = replaceVariables(dockerfile, buildArgs, /* not available in FROM instruction */ {}, stage.from.image, dockerfile.preamble, dockerfile.preamble.instructions.length);
 		const nextStage = dockerfile.stagesByLabel[image];
 		if (!nextStage) {

src/spec-shutdown/dockerUtils.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { CLIHost, runCommand, runCommandNoPty, ExecFunction, ExecParameters, Exec, PtyExecFunction, PtyExec, PtyExecParameters, plainExecAsPtyExec, PlatformInfo } from '../spec-common/commonUtils';
+import { CLIHost, runCommand, runCommandNoPty, ExecFunction, ExecParameters, Exec, PtyExecFunction, PtyExec, PtyExecParameters, plainExecAsPtyExec, PlatformInfo, GoARCH, GoOS } from '../spec-common/commonUtils';
 import { toErrorText } from '../spec-common/errors';
 import * as ptyType from 'node-pty';
 import { Log, makeLog } from '../spec-utils/log';
@@ -426,3 +426,20 @@ export function toDockerImageName(name: string) {
 		.replace(/[^a-z0-9\._-]+/g, '')
 		.replace(/(\.[\._-]|_[\.-]|__[\._-]|-+[\._])[\._-]*/g, (_, a) => a.substr(0, a.length - 1));
 }
+
+export interface ManifestDetail {
+	readonly schemaVersion: number;
+	readonly mediaType: string;
+	readonly manifests: readonly Manifest[];
+}
+
+export interface Manifest {
+	readonly mediaType: string;
+	readonly size: number;
+	readonly digest: string;
+	readonly platform: {
+		readonly architecture: GoARCH;
+		readonly os: GoOS;
+		readonly variant?: string;
+	};
+}