Rename category method to match prefix convention. Fix indentation.

Author: dempseyatgithub

BuildSettingExtractor/BuildSettingExtractor.m

@@ -175,14 +175,14 @@ - (NSArray *)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL error:(N
     self.buildSettingsByTarget[self.validatedProjectConfigName] = projectSettings;
 
     // Begin check that the project file has some settings
-    BOOL projectFileHasSettings = projectSettings.containsBuildSettings;
+    BOOL projectFileHasSettings = projectSettings.tps_containsBuildSettings;
 
     // Add project targets
     for (NSDictionary *target in targets) {
         NSString *targetName = target[@"name"];
         buildConfigurationListID = target[@"buildConfigurationList"];
         NSDictionary *targetSettings = [self buildSettingStringsByConfigurationForBuildConfigurationListID:buildConfigurationListID];
-        if (!projectFileHasSettings) { projectFileHasSettings = targetSettings.containsBuildSettings; }
+        if (!projectFileHasSettings) { projectFileHasSettings = targetSettings.tps_containsBuildSettings; }
 
         self.buildSettingsByTarget[targetName] = targetSettings;
 

BuildSettingExtractor/Constants+Categories.h

@@ -36,7 +36,7 @@ extern NSErrorDomain const TPSBuildSettingExtractorErrorDomain;
 // Assumes that a dictionary of build settings always has NSString values
 // Returns NO if all the values in a dictionary are an empty string
 // Raises an exception if used on a dictionary with any non-NSString value
-- (BOOL)containsBuildSettings;
+- (BOOL)tps_containsBuildSettings;
 
 // Returns a new dictionary containing all entries in the receiver except for
 // entries with an empty string value.

BuildSettingExtractor/Constants+Categories.m

@@ -56,20 +56,20 @@ - (NSString *)tps_baseBuildSettingName {
 
 @implementation NSDictionary (TPS_BuildSettingAdditions)
 
-    - (BOOL)containsBuildSettings {
-        BOOL foundNonEmptyString = NO;
-        for (id value in self.allValues) {
-            if ([value isKindOfClass:[NSString class]]) {
-                if (![(NSString *)value isEqualToString:@""]) {
-                    foundNonEmptyString = YES;
-                    break;
-                }
-            } else {
-                [NSException raise:(NSInternalInconsistencyException) format:@"-containsBuildSetting is expected to be called on a dictionary with NSString values."];
+- (BOOL)tps_containsBuildSettings {
+    BOOL foundNonEmptyString = NO;
+    for (id value in self.allValues) {
+        if ([value isKindOfClass:[NSString class]]) {
+            if (![(NSString *)value isEqualToString:@""]) {
+                foundNonEmptyString = YES;
+                break;
             }
+        } else {
+            [NSException raise:(NSInternalInconsistencyException) format:@"-containsBuildSetting is expected to be called on a dictionary with NSString values."];
         }
-        return foundNonEmptyString;
     }
+    return foundNonEmptyString;
+}
 
 - (NSDictionary *)tps_dictionaryByRemovingEmptyStringValues {
     NSMutableDictionary *temp = [[NSMutableDictionary alloc] init];

BuildSettingExtractorTests/BuildSettingExtractorTests.m

@@ -41,17 +41,17 @@ - (void)testThreeBuildConfigurations
 - (void)testDictionaryBuildSettingsCategory
 {
     NSDictionary *dictionaryWithBuildSettings = @{ @"Shared": @"COPY_PHASE_STRIP = NO", @"Release": @"COPY_PHASE_STRIP = NO", @"Debug": @"COPY_PHASE_STRIP = NO" };
-    XCTAssertTrue(dictionaryWithBuildSettings.containsBuildSettings);
+    XCTAssertTrue(dictionaryWithBuildSettings.tps_containsBuildSettings);
 
     NSDictionary *dictionaryWithMinimalBuildSettings = @{ @"Shared": @"", @"Release": @"", @"Debug": @"COPY_PHASE_STRIP = NO" };
-    XCTAssertTrue(dictionaryWithMinimalBuildSettings.containsBuildSettings);
+    XCTAssertTrue(dictionaryWithMinimalBuildSettings.tps_containsBuildSettings);
 
     NSDictionary *dictionaryWithoutBuildSettings = @{ @"Shared": @"", @"Release": @"", @"Debug": @"" };
-    XCTAssertFalse(dictionaryWithoutBuildSettings.containsBuildSettings);
+    XCTAssertFalse(dictionaryWithoutBuildSettings.tps_containsBuildSettings);
 
     NSDictionary *badDictionary = @{@"Shared":@"", @"Release":@"", @"Debug":[NSDate date] };
     BOOL result = NO;
-    XCTAssertThrows(result = badDictionary.containsBuildSettings);
+    XCTAssertThrows(result = badDictionary.tps_containsBuildSettings);
 }
 
 - (void)testLoadingBuildSettingInfo