Report extraction success. Don't open in Finder on failure.

Author: dempseyatgithub

BuildSettingExtractor/AppDelegate.m

@@ -68,10 +68,10 @@ - (IBAction)handleDroppedFile:(DragFileView *)sender {
                     buildSettingExtractor.nameSeparator = [defaults stringForKey:TPSOutputFileNameSeparator];
                     buildSettingExtractor.includeBuildSettingInfoComments = [[NSUserDefaults standardUserDefaults] boolForKey:TPSIncludeBuildSettingInfoComments];
 
-                    [buildSettingExtractor extractBuildSettingsFromProject:fileURL toDestinationFolder:destinationURL];
+                    BOOL success = [buildSettingExtractor extractBuildSettingsFromProject:fileURL toDestinationFolder:destinationURL];
 
                     BOOL openInFinder = [[NSUserDefaults standardUserDefaults] boolForKey:TPSOpenDirectoryInFinder];
-                    if (openInFinder) {
+                    if (success && openInFinder) {
                         [[NSWorkspace sharedWorkspace] openURL:destinationURL];
                     }
                 });

BuildSettingExtractor/BuildSettingExtractor.h

@@ -44,6 +44,7 @@
 // Should each build setting be commented with title and description, if available. 
 @property (assign) BOOL includeBuildSettingInfoComments;
 
-- (void)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestinationFolder:(NSURL *)folderURL;
+// Returns whether extraction of build settings was successful
+- (BOOL)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestinationFolder:(NSURL *)folderURL;
 
 @end

BuildSettingExtractor/BuildSettingExtractor.m

@@ -56,16 +56,18 @@ - (NSArray *)objectArrayForDictionary:(NSDictionary *)dict key:(NSString *)key {
     return objectArray;
 }
 
-- (void)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestinationFolder:(NSURL *)folderURL {
+- (BOOL)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestinationFolder:(NSURL *)folderURL {
 
     [self.buildSettingsByTarget removeAllObjects];
 
     NSError *error = nil;
+    BOOL success = YES;
 
     NSURL *projectFileURL = [projectWrapperURL URLByAppendingPathComponent:@"project.pbxproj"];
 
     NSData *fileData = [NSData dataWithContentsOfURL:projectFileURL options:0 error:&error];
     if (!fileData) {
+        success = NO;
         dispatch_async(dispatch_get_main_queue(), ^{
             [NSApp presentError:error];
         });
@@ -74,6 +76,7 @@ - (void)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestination
         NSDictionary *projectPlist = [NSPropertyListSerialization propertyListWithData:fileData options:NSPropertyListImmutable format:NULL error:&error];
 
         if (!projectPlist) {
+            success = NO;
             dispatch_async(dispatch_get_main_queue(), ^{
                 [NSApp presentError:error];
             });
@@ -88,10 +91,11 @@ - (void)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestination
             if (![compatibilityVersion isEqualToString:XcodeCompatibilityVersionString]) {
                 NSDictionary *userInfo = @{NSLocalizedDescriptionKey:[NSString stringWithFormat:@"Unable to extract build settings from project ‘%@’.", [[projectWrapperURL lastPathComponent] stringByDeletingPathExtension]], NSLocalizedRecoverySuggestionErrorKey: [NSString stringWithFormat:@"Project file format version ‘%@’ is not supported.", compatibilityVersion]};
                 NSError *error = [NSError errorWithDomain:[[NSBundle mainBundle] bundleIdentifier] code:UnsupportedXcodeVersion userInfo:userInfo];
+                success = NO;
                 dispatch_async(dispatch_get_main_queue(), ^{
                     [NSApp presentError:error];
                 });
-                return;
+                return success;
             }
 
             // Get project settings
@@ -116,6 +120,7 @@ - (void)extractBuildSettingsFromProject:(NSURL *)projectWrapperURL toDestination
             [self writeConfigFilesToDestinationFolder:folderURL];
         }
     }
+    return success;
 }