Skip to content

Commit ec2e6e0

Browse files
committed
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging
linux-user pull request 20210328 - Fix recvfrom with NULL msg - Fix sigreturn address on s390x # gpg: Signature made Sun 28 Mar 2021 17:05:45 BST # gpg: using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C # gpg: issuer "laurent@vivier.eu" # gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full] # gpg: aka "Laurent Vivier <laurent@vivier.eu>" [full] # gpg: aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" [full] # Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F 5173 F30C 38BD 3F2F BE3C * remotes/vivier2/tags/linux-user-for-6.0-pull-request: linux-user: allow NULL msg in recvfrom linux-user/s390x: Use the guest pointer for the sigreturn stub Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2 parents 7b9a3c9 + 4a1e6bc commit ec2e6e0

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

linux-user/s390x/signal.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,9 +211,10 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
211211
/* Set up to return from userspace. If provided, use a stub
212212
already in userspace. */
213213
if (ka->sa_flags & TARGET_SA_RESTORER) {
214-
env->regs[14] = (unsigned long) ka->sa_restorer | PSW_ADDR_AMODE;
214+
env->regs[14] = ka->sa_restorer | PSW_ADDR_AMODE;
215215
} else {
216-
env->regs[14] = (unsigned long) frame->retcode | PSW_ADDR_AMODE;
216+
env->regs[14] = (frame_addr + offsetof(typeof(*frame), retcode))
217+
| PSW_ADDR_AMODE;
217218
__put_user(S390_SYSCALL_OPCODE | TARGET_NR_rt_sigreturn,
218219
(uint16_t *)(frame->retcode));
219220
}

linux-user/syscall.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3679,9 +3679,14 @@ static abi_long do_recvfrom(int fd, abi_ulong msg, size_t len, int flags,
36793679
void *host_msg;
36803680
abi_long ret;
36813681

3682-
host_msg = lock_user(VERIFY_WRITE, msg, len, 0);
3683-
if (!host_msg)
3684-
return -TARGET_EFAULT;
3682+
if (!msg) {
3683+
host_msg = NULL;
3684+
} else {
3685+
host_msg = lock_user(VERIFY_WRITE, msg, len, 0);
3686+
if (!host_msg) {
3687+
return -TARGET_EFAULT;
3688+
}
3689+
}
36853690
if (target_addr) {
36863691
if (get_user_u32(addrlen, target_addrlen)) {
36873692
ret = -TARGET_EFAULT;

0 commit comments

Comments
 (0)