Skip to content

Commit 872cda9

Browse files
committed
tests/check-block.sh: Refuse to run the iotests with BusyBox' sed
BusyBox' sed reports itself as "This is not GNU sed version 4.0" when being run with the --version parameter. However, the iotests really need GNU sed, they do not work with the BusyBox version. So let's make sure that we really have GNU sed and refuse to run the tests with BusyBox' sed. Signed-off-by: Thomas Huth <thuth@redhat.com> Message-Id: <20210119134749.401311-1-thuth@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
1 parent 8df04b0 commit 872cda9

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tests/check-block.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@ if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then
6060
echo "GNU sed not available ==> Not running the qemu-iotests."
6161
exit 0
6262
fi
63+
else
64+
# Double-check that we're not using BusyBox' sed which says
65+
# that "This is not GNU sed version 4.0" ...
66+
if sed --version | grep -q 'not GNU sed' ; then
67+
echo "BusyBox sed not supported ==> Not running the qemu-iotests."
68+
exit 0
69+
fi
6370
fi
6471

6572
cd tests/qemu-iotests

0 commit comments

Comments
 (0)