Skip to content

Commit 73b1230

Browse files
paguptamstsirkin
authored andcommitted
virtio-pmem: add trace events
This patch adds trace events for virtio-pmem functionality. Adding trace events for virtio pmem request, reponse and host side fsync functionality. Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com> Message-Id: <20201117115705.32195-1-pankaj.gupta.linux@gmail.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent f6ab64c commit 73b1230

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

hw/virtio/trace-events

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,3 +122,8 @@ virtio_mem_unplug_all_request(void) ""
122122
virtio_mem_resized_usable_region(uint64_t old_size, uint64_t new_size) "old_size=0x%" PRIx64 "new_size=0x%" PRIx64
123123
virtio_mem_state_request(uint64_t addr, uint16_t nb_blocks) "addr=0x%" PRIx64 " nb_blocks=%" PRIu16
124124
virtio_mem_state_response(uint16_t state) "state=%" PRIu16
125+
126+
# virtio-pmem.c
127+
virtio_pmem_flush_request(void) "flush request"
128+
virtio_pmem_response(void) "flush response"
129+
virtio_pmem_flush_done(int type) "fsync return=%d"

hw/virtio/virtio-pmem.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include "sysemu/hostmem.h"
2525
#include "block/aio.h"
2626
#include "block/thread-pool.h"
27+
#include "trace.h"
2728

2829
typedef struct VirtIODeviceRequest {
2930
VirtQueueElement elem;
@@ -41,6 +42,7 @@ static int worker_cb(void *opaque)
4142

4243
/* flush raw backing image */
4344
err = fsync(req_data->fd);
45+
trace_virtio_pmem_flush_done(err);
4446
if (err != 0) {
4547
err = 1;
4648
}
@@ -59,6 +61,7 @@ static void done_cb(void *opaque, int ret)
5961
/* Callbacks are serialized, so no need to use atomic ops. */
6062
virtqueue_push(req_data->pmem->rq_vq, &req_data->elem, len);
6163
virtio_notify((VirtIODevice *)req_data->pmem, req_data->pmem->rq_vq);
64+
trace_virtio_pmem_response();
6265
g_free(req_data);
6366
}
6467

@@ -69,6 +72,7 @@ static void virtio_pmem_flush(VirtIODevice *vdev, VirtQueue *vq)
6972
HostMemoryBackend *backend = MEMORY_BACKEND(pmem->memdev);
7073
ThreadPool *pool = aio_get_thread_pool(qemu_get_aio_context());
7174

75+
trace_virtio_pmem_flush_request();
7276
req_data = virtqueue_pop(vq, sizeof(VirtIODeviceRequest));
7377
if (!req_data) {
7478
virtio_error(vdev, "virtio-pmem missing request data");

0 commit comments

Comments
 (0)