From fee29d97a5ad24d32178dc563b34a42bdab202a6 Mon Sep 17 00:00:00 2001
From: Yaroslav Halchenko <debian@onerussian.com>
Date: Mon, 13 Mar 2023 13:51:01 -0400
Subject: [PATCH 1/2] Add github action to shellcheck master on push and PRs

---
 .github/workflows/shellcheck.yml | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 .github/workflows/shellcheck.yml

diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml
new file mode 100644
index 000000000..087aba768
--- /dev/null
+++ b/.github/workflows/shellcheck.yml
@@ -0,0 +1,23 @@
+---
+name: Shellcheck
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  shellcheck:
+    name: Check shell scripts
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Install dependencies
+        run: |
+          sudo apt update && sudo apt install -y shellcheck
+      - name: shellcheck
+        run: |
+          git grep -l '^#\( *shellcheck \|!\(/bin/\|/usr/bin/env \)\(sh\|bash\|dash\|ksh\)\)' | xargs shellcheck 

From 2c7524d106d6b4fa397ff5b32839d086d065c871 Mon Sep 17 00:00:00 2001
From: Yaroslav Halchenko <debian@onerussian.com>
Date: Mon, 13 Mar 2023 13:53:25 -0400
Subject: [PATCH 2/2] Make package-macos.sh shellcheck clean - read -r and
 quotes

---
 package-macos.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package-macos.sh b/package-macos.sh
index a143f3047..f6066aaa7 100755
--- a/package-macos.sh
+++ b/package-macos.sh
@@ -6,8 +6,8 @@ cp -r target/jfx/native/datavyu.app target/jfx/native/Datavyu/
 ln -s /Applications target/jfx/native/Datavyu/
 
 echo version number:
-read version
+read -r version
 
-sudo hdiutil create -fs HFS+ target/jfx/native/Datavyu-$version-OSX.dmg -volname "Datavyu" -srcfolder target/jfx/native/Datavyu
+sudo hdiutil create -fs HFS+ "target/jfx/native/Datavyu-$version-OSX.dmg" -volname "Datavyu" -srcfolder target/jfx/native/Datavyu
 
 rm -rf target/jfx/native/Datavyu