Skip to content

[Task] Add //clang-format off/on to protect all Cycamore Pragmas for clang-format #643

@dean-krueger

Description

@dean-krueger

What is this task about?

All #pragma blocks in Cycamore need to be surrounded by //clang-format off and //clang-format on.

Why is this task needed?

cyclus/cyclus#1674 is attempting to add a step to the GH workflow which will test code formatting against a clang-formatted version of the code. Because of this, all cyclus and cycamore code will become subject to being formatted in this way. However, an issue was discovered in the way that clang-format interacts with the JSON-formatted #pragma sections of Cycamore .h files. To prevent this, these blocks of code will need to be manually protected by surrounding them with //clang-format off and //clang-format on.

Relevant resources or references

None.

How can this issue be closed?

Once all cycamore files can be safely clang-formatted and cycamore can still build this will be good to close.

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions