Merge pull request #257 from coopdevs/fix/remove-devise-session-flash-messages

Remove devise session flash messages

Author: enricostano

app/controllers/sessions_controller.rb

@@ -0,0 +1,14 @@
+class SessionsController < Devise::SessionsController
+
+  # POST /resource/sign_in
+  def create
+    super
+    flash.delete(:notice)
+  end
+
+  # DELETE /resource/sign_out
+  def destroy
+    super
+    flash.delete(:notice)
+  end
+end

config/locales/ca.yml

@@ -242,8 +242,6 @@ ca:
       new:
         remember_me: Recorda'm
         sign_in: Entrar
-      signed_in: 
-      signed_out: 
     shared:
       links:
         didnt_receive_confirmation_instructions: Tornar a enviar correu de confirmació

config/locales/en.yml

@@ -242,8 +242,6 @@ en:
       new:
         remember_me: Remember me
         sign_in: Login
-      signed_in: 
-      signed_out: 
     shared:
       links:
         didnt_receive_confirmation_instructions: Resend confirmation email

config/locales/es.yml

@@ -245,8 +245,6 @@ es:
       new:
         remember_me: Recordarme
         sign_in: Entrar
-      signed_in: 
-      signed_out: 
       user:
         signed_in: 
     shared:

config/locales/pt-BR.yml

@@ -245,8 +245,6 @@ pt-BR:
       new:
         remember_me: Lembrar de mim
         sign_in: Entrar
-      signed_in: 
-      signed_out: 
       user:
         signed_in: 
     shared:

config/routes.rb

@@ -1,7 +1,7 @@
 Rails.application.routes.draw do
   root to: "home#index"
 
-  devise_for :users
+  devise_for :users, controllers: { sessions: "sessions" }
 
   devise_scope :user do
     get "login", to: "devise/sessions#new"

spec/controllers/sessions_controller_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe SessionsController do
+  let(:user) do
+    Fabricate(:user, password: 'papapa22', password_confirmation: 'papapa22')
+  end
+
+  describe '#create' do
+    before do
+      request.env["devise.mapping"] = Devise.mappings[:user]
+    end
+
+    it 'does not show a notice flash message' do
+      post :create, user: {
+        email: user.email,
+        password: user.password
+      }
+      expect(flash[:notice]).to be_nil
+    end
+  end
+
+  describe '#destroy' do
+    before do
+      request.env["devise.mapping"] = Devise.mappings[:user]
+      post :create, user: {
+        email: user.email,
+        password: user.password
+      }
+    end
+
+    it 'does not show a notice flash message' do
+      delete :destroy
+      expect(flash[:notice]).to be_nil
+    end
+  end
+end

spec/spec_helper.rb

@@ -6,6 +6,10 @@
 require 'rspec/rails'
 require 'rspec/autorun'
 require 'capybara/rails'
+require 'database_cleaner'
+require 'fabrication'
+require 'faker'
+I18n.reload!
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.