Migrate linter to rubocop-rails-omakase

Author: markets

.rubocop.yml

@@ -1,244 +1,25 @@
-require: rubocop-rails
+# Omakase Ruby styling for Rails
+inherit_gem:
+  rubocop-rails-omakase: rubocop.yml
 
+# Your own specialized rules go here
 AllCops:
   Exclude:
-    - db/schema.rb
+    - "db/**/*"
+    - "config/**/*"
 
-Naming/AccessorMethodName:
+Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: false
-
-Rails/HttpPositionalArguments:
-  Enabled: true
-
-Style/Alias:
-  Enabled: false
-
-Style/ArrayJoin:
-  Enabled: false
-
-Style/AsciiComments:
-  Enabled: false
-
-Naming/AsciiIdentifiers:
-  Enabled: false
-
-Style/Attr:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Style/CaseEquality:
-  Enabled: false
-
-Style/CharacterLiteral:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
+Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Style/ClassVars:
-  Enabled: false
-
-Style/CollectionMethods:
-  PreferredMethods:
-    find: detect
-    reduce: inject
-    collect: map
-    find_all: select
-
-Style/ColonMethodCall:
-  Enabled: false
-
-Style/CommentAnnotation:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
+Layout/CaseIndentation:
   Enabled: false
-
-Style/Documentation:
+Layout/EndAlignment:
   Enabled: false
-
-Layout/DotPosition:
-  EnforcedStyle: trailing
-
-Layout/ConditionPosition:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/EachWithObject:
-  Enabled: false
-
-Style/EmptyLiteral:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
-Style/EvenOdd:
-  Enabled: false
-
-Naming/FileName:
-  Enabled: false
-
-Style/FormatString:
-  Enabled: false
-
-Style/GlobalVars:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/IfWithSemicolon:
-  Enabled: false
-
-Style/InlineComment:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-Style/LambdaCall:
-  Enabled: false
-
-Style/LineEndConcatenation:
-  Enabled: false
-
-Layout/LineLength:
-  Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/ModuleFunction:
-  Enabled: false
-
-Style/NegatedIf:
-  Enabled: false
-
-Style/NegatedWhile:
-  Enabled: false
-
-Style/Next:
-  Enabled: false
-
-Style/NilComparison:
-  Enabled: false
-
-Style/Not:
-  Enabled: false
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/OneLineConditional:
-  Enabled: false
-
-Metrics/ParameterLists:
+Layout/ElseAlignment:
   Enabled: false
 
 Style/PercentLiteralDelimiters:
   Enabled: false
-
-Style/PerlBackrefs:
-  Enabled: false
-
-Naming/PredicateName:
-  ForbiddenPrefixes:
-    - is_
-
-Style/Proc:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Style/RegexpLiteral:
-  Enabled: false
-
-Style/SelfAssignment:
-  Enabled: false
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Style/SingleLineMethods:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/SpecialGlobalVars:
-  Enabled: false
-
 Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/VariableInterpolation:
-  Enabled: false
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: false
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: false
-
-Style/TrailingCommaInArguments:
-  Enabled: false
-
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/WhenThen:
-  Enabled: false
-
-Style/WhileUntilModifier:
-  Enabled: false
-
-Lint/AmbiguousOperator:
-  Enabled: false
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-Lint/AssignmentInCondition:
-  Enabled: false
-
-Lint/DeprecatedClassMethods:
-  Enabled: false
-
-Lint/ElseLayout:
-  Enabled: false
-
-Lint/SuppressedException:
-  Enabled: false
-
-Lint/LiteralInInterpolation:
-  Enabled: false
-
-Lint/Loop:
-  Enabled: false
-
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
-
-Lint/RequireParentheses:
-  Enabled: false
-
-Lint/UnderscorePrefixedVariableName:
-  Enabled: false
-
-Lint/Void:
-  Enabled: false
-
-Lint/FlipFlop:
   Enabled: false

Gemfile

@@ -45,8 +45,7 @@ end
 
 group :development, :test do
   gem 'byebug', '~> 11.0'
-  gem 'rubocop', '~> 1.6', require: false
-  gem 'rubocop-rails', '~> 2.9', require: false
+  gem 'rubocop-rails-omakase', require: false
   gem 'dotenv-rails', '~> 3.1.7'
 end
 

Gemfile.lock

@@ -92,7 +92,7 @@ GEM
     arbre (1.7.0)
       activesupport (>= 3.0.0)
       ruby2_keywords (>= 0.0.2)
-    ast (2.4.2)
+    ast (2.4.3)
     autoprefixer-rails (10.4.19.0)
       execjs (~> 2)
     aws-eventstream (1.3.0)
@@ -206,7 +206,7 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    json (2.9.1)
+    json (2.10.2)
     json_translate (4.0.1)
       activerecord (>= 4.2.0)
     kaminari (1.2.2)
@@ -221,11 +221,12 @@ GEM
       activerecord
       kaminari-core (= 1.2.2)
     kaminari-core (1.2.2)
-    language_server-protocol (3.17.0.3)
+    language_server-protocol (3.17.0.4)
     launchy (2.5.2)
       addressable (~> 2.8)
     letter_opener (1.7.0)
       launchy (~> 2.2)
+    lint_roller (1.1.0)
     localeapp (3.3.0)
       gli
       i18n (>= 0.7, < 2)
@@ -267,7 +268,7 @@ GEM
       racc (~> 1.4)
     orm_adapter (0.5.0)
     parallel (1.26.3)
-    parser (3.3.6.0)
+    parser (3.3.7.2)
       ast (~> 2.4.1)
       racc
     pdf-core (0.10.0)
@@ -378,23 +379,33 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.2)
-    rubocop (1.69.2)
+    rubocop (1.74.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.37.0)
-      parser (>= 3.3.1.0)
-    rubocop-rails (2.28.0)
+    rubocop-ast (1.41.0)
+      parser (>= 3.3.7.2)
+    rubocop-performance (1.24.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.30.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.52.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails-omakase (1.1.0)
+      rubocop (>= 1.72)
+      rubocop-performance (>= 1.24)
+      rubocop-rails (>= 2.30)
     ruby-progressbar (1.13.0)
     ruby-vips (2.2.2)
       ffi (~> 1.12)
@@ -453,7 +464,7 @@ GEM
       concurrent-ruby (~> 1.0)
     uglifier (4.2.1)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (3.1.3)
+    unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     useragent (0.16.11)
@@ -513,8 +524,7 @@ DEPENDENCIES
   rails-i18n (~> 7.0)
   rdiscount (~> 2.2.7)
   rspec-rails (~> 6.0)
-  rubocop (~> 1.6)
-  rubocop-rails (~> 2.9)
+  rubocop-rails-omakase
   rubyzip (~> 2.3.0)
   sassc-rails (~> 2.1.2)
   select2-rails (~> 4.0.13)

README.md

@@ -101,12 +101,18 @@ In order to configure the application you can use the following ENV variables:
 
 Any kind of feedback, bug report, idea or enhancement are really appreciated.
 
-To contribute, just fork the repo, hack on it and send a pull request. Don't forget to add tests for behaviour changes and run the test suite:
+To contribute, just fork the repo, hack on it and send a pull request. Don't forget to add tests for behaviour changes and run the test suite by:
 
 ```
 bundle exec rspec
 ```
 
+You can also run the linter by:
+
+```
+bundle exec rubocop
+```
+
 👉 Further information in our [Wiki](https://github.com/coopdevs/timeoverflow/wiki).
 
 ## License

app/controllers/concerns/with_transfer_params.rb

@@ -4,7 +4,7 @@ def transfer_params
       :destination,
       :amount,
       :reason,
-      :post_id,
+      :post_id
     ]
 
     permitted_transfer_params.push(:source) if admin?