new tests offers visibility

Author: gmartincor

spec/controllers/offers_controller_spec.rb

@@ -52,6 +52,32 @@
           expect(assigns(:offers)).to eq([other_offer])
         end
       end
+
+      context "when filtering by organization" do
+        let(:organization1) { Organization.find_by(name: "Banco de Tiempo Local") }
+        let(:organization2) { Organization.find_by(name: "El otro Banco de Tiempo :)") }
+        let(:user1) { User.find_by(email: "user@timeoverflow.org") }
+        let(:user2) { User.find_by(email: "user2@timeoverflow.org") }
+        let!(:offer1) { Offer.find_by(title: "Ruby on Rails nivel principiante") ||
+                       Fabricate(:offer, user: user1, title: "Ruby on Rails nivel principiante") }
+        let!(:offer2) { Offer.find_by(title: "Cocina low cost") ||
+                       Fabricate(:offer, user: user2, title: "Cocina low cost") }
+
+        before { login(user1) }
+
+        it 'displays only offers from the selected organization' do
+          get :index, params: { organization_id: organization1.id }
+
+          expect(assigns(:offers)).to include(offer1)
+          expect(assigns(:offers)).not_to include(offer2)
+        end
+
+        it 'displays all offers when no organization is selected' do
+          get :index
+
+          expect(assigns(:offers)).to include(offer1, offer2)
+        end
+      end
     end
 
     context "with another organization" do

spec/features/Offers_organization_filtering_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+RSpec.feature 'Offers organization filtering' do
+  let(:organization) { Fabricate(:organization) }
+  let(:other_organization) { Fabricate(:organization) }
+  let(:category) { Fabricate(:category) }
+  let(:member) { Fabricate(:member, organization: organization) }
+  let(:other_member) { Fabricate(:member, organization: other_organization) }
+  let(:user) { member.user }
+
+  before do
+    user.terms_accepted_at = Time.current
+    user.save!
+
+    # Create an accepted alliance
+    OrganizationAlliance.create!(
+      source_organization: organization,
+      target_organization: other_organization,
+      status: "accepted"
+    )
+
+    # Create posts in both organizations
+    Fabricate(:offer,
+             user: user,
+             organization: organization,
+             category: category,
+             title: "Local offer",
+             active: true)
+
+    Fabricate(:offer,
+             user: other_member.user,
+             organization: other_organization,
+             category: category,
+             title: "Allied offer",
+             active: true)
+
+    # Log in as user
+    sign_in_with(user.email, user.password)
+  end
+
+  scenario 'User filters posts by allied organization' do
+    visit offers_path
+
+    # Should see posts from both organizations by default
+    expect(page).to have_content("Local offer")
+    expect(page).to have_content("Allied offer")
+
+    # Click on the organization dropdown toggle
+    find('a.dropdown-toggle', text: Organization.model_name.human(count: :other)).click
+
+    # Find the organization in the dropdown menu and click it directly by url
+    query_params = { org: other_organization.id }
+    link_path = "#{offers_path}?#{query_params.to_query}"
+    visit link_path
+
+    # Should see only posts from selected organization
+    expect(page).to have_content("Allied offer")
+    expect(page).not_to have_content("Local offer")
+  end
+end

spec/models/post_spec.rb

@@ -6,4 +6,29 @@
     it { is_expected.to have_many(:movements) }
     it { is_expected.to have_many(:events) }
   end
+
+  describe '.by_organizations' do
+    let(:organization) { Fabricate(:organization) }
+    let(:other_organization) { Fabricate(:organization) }
+    let(:member) { Fabricate(:member, organization: organization) }
+    let(:other_member) { Fabricate(:member, organization: other_organization) }
+    let(:category) { Fabricate(:category) }
+    let!(:post1) { Fabricate(:offer, user: member.user, organization: organization, category: category) }
+    let!(:post2) { Fabricate(:offer, user: other_member.user, organization: other_organization, category: category) }
+
+    it 'returns posts from the specified organizations' do
+      expect(Post.by_organizations([organization.id])).to include(post1)
+      expect(Post.by_organizations([organization.id])).not_to include(post2)
+
+      expect(Post.by_organizations([other_organization.id])).to include(post2)
+      expect(Post.by_organizations([other_organization.id])).not_to include(post1)
+
+      expect(Post.by_organizations([organization.id, other_organization.id])).to include(post1, post2)
+    end
+
+    it 'returns all posts if no organization ids are provided' do
+      expect(Post.by_organizations(nil)).to include(post1, post2)
+      expect(Post.by_organizations([])).to include(post1, post2)
+    end
+  end
 end